Refine error messages for Move-AzureRmResource

Author: Tiano2017

src/ResourceManager/Resources/Commands.ResourceManager/Cmdlets/Implementation/Resource/MoveAzureResourceCmdlet.cs

@@ -105,14 +105,19 @@ private void RunCmdlet()
                 .Where(resourceGroupId => !string.IsNullOrWhiteSpace(resourceGroupId))
                 .DistinctArray(StringComparer.InvariantCultureIgnoreCase);
 
-            var sourceResourceGroup = sourceResourceGroups.SingleOrDefault();
-
-            if (sourceResourceGroup == null)
+            var count = sourceResourceGroups.Count();
+            if (count == 0)
+            {
+                throw new InvalidOperationException("At least one valid resource Id must be provided.");
+            }
+            else if (count > 1)
             {
                 throw new InvalidOperationException(
                     string.Format("The resources being moved must all reside in the same resource group. The resources: {0}", resourceIdsToUse.ConcatStrings(", ")));
             }
 
+            var sourceResourceGroup = sourceResourceGroups.Single();
+
             var destinationResourceGroup = ResourceIdUtility.GetResourceId(
                 subscriptionId: this.DestinationSubscriptionId,
                 resourceGroupName: this.DestinationResourceGroupName,

src/ResourceManager/Resources/Commands.Resources.Test/Commands.Resources.Test.csproj

@@ -556,6 +556,9 @@
     <None Include="SessionRecords\Microsoft.Azure.Commands.Resources.Test.ScenarioTests.ResourceTests\TestMoveAResourceTest.json">
       <CopyToOutputDirectory>Always</CopyToOutputDirectory>
     </None>
+    <None Include="SessionRecords\Microsoft.Azure.Commands.Resources.Test.ScenarioTests.ResourceTests\TestMoveResourceFailed.json">
+      <CopyToOutputDirectory>Always</CopyToOutputDirectory>
+    </None>
     <None Include="SessionRecords\Microsoft.Azure.Commands.Resources.Test.ScenarioTests.ResourceTests\TestSetAResourceTest.json">
       <CopyToOutputDirectory>Always</CopyToOutputDirectory>
     </None>

src/ResourceManager/Resources/Commands.Resources.Test/ScenarioTests/ResourceTests.cs

@@ -91,6 +91,13 @@ public void TestMoveAResourceTest()
             ResourcesController.NewInstance.RunPsTest("Test-MoveAResource");
         }
 
+        [Fact]
+        [Trait(Category.AcceptanceType, Category.CheckIn)]
+        public void TestMoveResourceFailed()
+        {
+            ResourcesController.NewInstance.RunPsTest("Test-MoveResourceFailed");
+        }
+
         [Fact]
         [Trait(Category.AcceptanceType, Category.CheckIn)]
         public void TestSetAResourceTest()

src/ResourceManager/Resources/Commands.Resources.Test/ScenarioTests/ResourceTests.ps1

@@ -245,6 +245,23 @@ function Test-MoveAResource
 	Assert-AreEqual $movedResource.ResourceType $resource.ResourceType
 }
 
+<#
+.SYNOPSIS
+Tests moving a resource but failed.
+#>
+function Test-MoveResourceFailed
+{
+	#Move a resource through pipeline while no resource is sent
+	$exceptionMessage = "At least one valid resource Id must be provided.";
+	Assert-Throws { Get-AzureRmResource | Where-Object { $PSItem.Name -eq "NonExistingResource" } | Move-AzureRmResource -DestinationResourceGroupName "AnyResourceGroup" } $exceptionMessage
+
+	#Move two resources from two resource groups
+	$resourceId1 = "/subscriptions/fb3a3d6b-44c8-44f5-88c9-b20917c9b96b/resourceGroups/tianorg1/providers/Microsoft.Storage/storageAccounts/temp1"
+	$resourceId2 = "/subscriptions/fb3a3d6b-44c8-44f5-88c9-b20917c9b96b/resourceGroups/tianorg2/providers/Microsoft.Storage/storageAccounts/temp1"
+	$exceptionMessage = "The resources being moved must all reside in the same resource group. The resources: *"
+	Assert-ThrowsLike { Move-AzureRmResource -DestinationResourceGroupName "AnyGroup" -ResourceId @($resourceId1, $resourceId2) } $exceptionMessage
+}
+
 <#
 .SYNOPSIS
 Tests setting a resource.