Skip to content

Commit fc344d1

Browse files
committed
Fix a null reference issue in New-AzureRmStorageAccount
1 parent 3b39090 commit fc344d1

File tree

5 files changed

+4622
-1
lines changed

5 files changed

+4622
-1
lines changed

src/ResourceManager/Storage/Commands.Management.Storage.Test/Commands.Management.Storage.Test.csproj

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -203,6 +203,9 @@
203203
<None Include="SessionRecords\Microsoft.Azure.Commands.Management.Storage.Test.ScenarioTests.StorageAccountTests\TestSetAzureStorageAccountStorageV2.json">
204204
<CopyToOutputDirectory>Always</CopyToOutputDirectory>
205205
</None>
206+
<None Include="SessionRecords\Microsoft.Azure.Commands.Management.Storage.Test.ScenarioTests.StorageAccountTests\TestNewAzureStorageAccountEncryptionServiceNone.json">
207+
<CopyToOutputDirectory>Always</CopyToOutputDirectory>
208+
</None>
206209
</ItemGroup>
207210
<ItemGroup>
208211
<Service Include="{82A7F48D-3B50-4B1E-B82E-3ADA8210C358}" />

src/ResourceManager/Storage/Commands.Management.Storage.Test/ScenarioTests/StorageAccountTests.cs

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -118,5 +118,12 @@ public void TestSetAzureStorageAccountStorageV2()
118118
{
119119
TestController.NewInstance.RunPsTest("Test-SetAzureStorageAccountStorageV2");
120120
}
121+
122+
[Fact]
123+
[Trait(Category.AcceptanceType, Category.CheckIn)]
124+
public void TestNewAzureStorageAccountEncryptionServiceNone()
125+
{
126+
TestController.NewInstance.RunPsTest("Test-NewAzureStorageAccountEncryptionServiceNone");
127+
}
121128
}
122129
}

src/ResourceManager/Storage/Commands.Management.Storage.Test/ScenarioTests/StorageAccountTests.ps1

Lines changed: 56 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -656,4 +656,60 @@ function Test-SetAzureStorageAccountStorageV2
656656
# Cleanup
657657
Clean-ResourceGroup $rgname
658658
}
659+
}
660+
661+
662+
<#
663+
.SYNOPSIS
664+
Test NewSetAzureStorageAccount with EncryptionService None
665+
.Description
666+
AzureAutomationTest
667+
#>
668+
function Test-NewAzureStorageAccountEncryptionServiceNone
669+
{
670+
# Setup
671+
$rgname = Get-StorageManagementTestResourceName;
672+
673+
try
674+
{
675+
# Test
676+
$stoname = 'sto' + $rgname;
677+
$stotype = 'Standard_GRS';
678+
$loc = Get-ProviderLocation ResourceManagement;
679+
$kind = 'StorageV2'
680+
681+
New-AzureRmResourceGroup -Name $rgname -Location $loc;
682+
$loc = Get-ProviderLocation_Stage ResourceManagement;
683+
New-AzureRmStorageAccount -ResourceGroupName $rgname -Name $stoname -Location $loc -Type $stotype -Kind $kind -EnableEncryptionService None;
684+
685+
Retry-IfException { $global:sto = Get-AzureRmStorageAccount -ResourceGroupName $rgname -Name $stoname; }
686+
$stotype = 'StandardGRS';
687+
Assert-AreEqual $sto.StorageAccountName $stoname;
688+
Assert-AreEqual $sto.Sku.Name $stotype;
689+
Assert-AreEqual $sto.Location $loc;
690+
Assert-AreEqual $sto.Kind $kind;
691+
692+
Set-AzureRmStorageAccount -ResourceGroupName $rgname -Name $stoname -EnableHttpsTrafficOnly $true -EnableEncryptionService None;
693+
$sto = Get-AzureRmStorageAccount -ResourceGroupName $rgname -Name $stoname;
694+
Assert-AreEqual $sto.StorageAccountName $stoname;
695+
Assert-AreEqual $sto.Sku.Name $stotype;
696+
Assert-AreEqual $sto.Location $loc;
697+
Assert-AreEqual $sto.Kind $kind;
698+
Assert-AreEqual $sto.EnableHttpsTrafficOnly $true;
699+
700+
Set-AzureRmStorageAccount -ResourceGroupName $rgname -Name $stoname -EnableHttpsTrafficOnly $false -DisableEncryptionService None;
701+
$sto = Get-AzureRmStorageAccount -ResourceGroupName $rgname -Name $stoname;
702+
Assert-AreEqual $sto.StorageAccountName $stoname;
703+
Assert-AreEqual $sto.Sku.Name $stotype;
704+
Assert-AreEqual $sto.Location $loc;
705+
Assert-AreEqual $sto.Kind $kind;
706+
Assert-AreEqual $sto.EnableHttpsTrafficOnly $false;
707+
708+
Remove-AzureRmStorageAccount -Force -ResourceGroupName $rgname -Name $stoname;
709+
}
710+
finally
711+
{
712+
# Cleanup
713+
Clean-ResourceGroup $rgname
714+
}
659715
}

0 commit comments

Comments
 (0)