Taking pr comments

Author: NehaRaje

src/ServiceManagement/RecoveryServices/Commands.RecoveryServices/Service/CreateAzureSiteRecoveryProtectionProfileObject.cs

@@ -35,8 +35,8 @@ public class CreateAzureSiteRecoveryProtectionProfileObject : RecoveryServicesCm
         [Parameter(ParameterSetName = ASRParameterSets.Default, Mandatory = true)]
         [ValidateNotNullOrEmpty]
         [ValidateSet(
-            "HyperVReplica",
-            "HyperVReplicaAzure")]
+            Constants.HyperVReplica,
+            Constants.HyperVReplicaAzure)]
         public string ReplicationProvider { get; set; }
 
         /// <summary>
@@ -46,8 +46,8 @@ public class CreateAzureSiteRecoveryProtectionProfileObject : RecoveryServicesCm
         [Parameter(ParameterSetName = ASRParameterSets.EnterpriseToAzure, Mandatory = true)]
         [ValidateNotNullOrEmpty]
         [ValidateSet(
-            "Online",
-            "Offline")]
+            Constants.OnlineReplicationMethod,
+            Constants.OfflineReplicationMethod)]
         public string ReplicationMethod { get; set; }
 
         /// <summary>
@@ -132,10 +132,10 @@ public override void ExecuteCmdlet()
             {
                 switch (this.ReplicationProvider)
                 {
-                    case "HyperVReplica":
+                    case Constants.HyperVReplica:
                         this.EnterpriseToEnterpriseProtectionProfileObject();
                         break;
-                    case "HyperVReplicaAzure":
+                    case Constants.HyperVReplicaAzure:
                         this.EnterpriseToAzureProtectionProfileObject();
                         break;
                 }

src/ServiceManagement/RecoveryServices/Commands.RecoveryServices/lib/PSObjects.cs

@@ -306,6 +306,7 @@ public ASRProtectionContainer(ProtectionContainer pc)
                     {
                         asrProtectionProfile.HyperVReplicaProviderSettingsObject.AssociationDetail = new List<ASRProtectionProfileAssociationDetails>();
                     }
+
                     foreach (var profileAssosicationDetail in profile.AssociationDetail)
                     {
                         var asrProfileDetail = new ASRProtectionProfileAssociationDetails();
@@ -349,7 +350,6 @@ public ASRProtectionContainer(ProtectionContainer pc)
                             = details.RecoveryPointHistoryDuration;
 
                         asrProtectionProfile.HyperVReplicaAzureProviderSettingsObject.CanDissociate = profile.CanDissociate;
-
                     }
                     else if (profile.ReplicationProvider == Constants.HyperVReplica)
                     {