App Config Provider - Missing tests (#39988)

* Stops loading feature flags as configurations

* cleaning up a bit

* bug fix and new recordings

* Update assets.json

* formatting

* added tests

* spelling

Author: mrm9084

sdk/appconfiguration/azure-appconfiguration-provider/azure/appconfiguration/provider/_azureappconfigurationprovider.py

@@ -360,7 +360,7 @@ def refresh(self, **kwargs) -> None:  # pylint: disable=too-many-statements
                         need_refresh, self._refresh_on, configuration_settings = client.refresh_configuration_settings(
                             self._selects, self._refresh_on, headers=headers, **kwargs
                         )
-                        configuration_settings_processed = self._proccess_configurations(configuration_settings)
+                        configuration_settings_processed = self._process_configurations(configuration_settings)
                         if need_refresh:
                             self._dict = configuration_settings_processed
                     if self._feature_flag_refresh_enabled:
@@ -422,7 +422,7 @@ def _load_all(self, **kwargs):
                 configuration_settings, sentinel_keys = client.load_configuration_settings(
                     self._selects, self._refresh_on, headers=headers, **kwargs
                 )
-                configuration_settings_processed = self._proccess_configurations(configuration_settings)
+                configuration_settings_processed = self._process_configurations(configuration_settings)
                 if self._feature_flag_enabled:
                     feature_flags, feature_flag_sentinel_keys, used_filters = client.load_feature_flags(
                         self._feature_flag_selectors, self._feature_flag_refresh_enabled, headers=headers, **kwargs
@@ -461,7 +461,7 @@ def _load_all(self, **kwargs):
                 is_failover_request = True
         raise exception
 
-    def _proccess_configurations(self, configuration_settings: List[ConfigurationSetting]) -> Dict[str, Any]:
+    def _process_configurations(self, configuration_settings: List[ConfigurationSetting]) -> Dict[str, Any]:
         configuration_settings_processed = {}
         for config in configuration_settings:
             if isinstance(config, FeatureFlagConfigurationSetting):

sdk/appconfiguration/azure-appconfiguration-provider/azure/appconfiguration/provider/aio/_azureappconfigurationproviderasync.py

@@ -377,7 +377,7 @@ async def refresh(self, **kwargs) -> None:  # pylint: disable=too-many-statement
                                 self._selects, self._refresh_on, headers=headers, **kwargs
                             )
                         )
-                        configuration_settings_processed = await self._proccess_configurations(configuration_settings)
+                        configuration_settings_processed = await self._process_configurations(configuration_settings)
                         if need_refresh:
                             self._dict = configuration_settings_processed
                     if self._feature_flag_refresh_enabled:
@@ -439,7 +439,7 @@ async def _load_all(self, **kwargs):
                 configuration_settings, sentinel_keys = await client.load_configuration_settings(
                     self._selects, self._refresh_on, headers=headers, **kwargs
                 )
-                configuration_settings_processed = await self._proccess_configurations(configuration_settings)
+                configuration_settings_processed = await self._process_configurations(configuration_settings)
                 if self._feature_flag_enabled:
                     feature_flags, feature_flag_sentinel_keys, used_filters = await client.load_feature_flags(
                         self._feature_flag_selectors, self._feature_flag_refresh_enabled, headers=headers, **kwargs
@@ -480,7 +480,7 @@ async def _load_all(self, **kwargs):
                 is_failover_request = True
         raise exception
 
-    async def _proccess_configurations(self, configuration_settings: List[ConfigurationSetting]) -> Dict[str, Any]:
+    async def _process_configurations(self, configuration_settings: List[ConfigurationSetting]) -> Dict[str, Any]:
         configuration_settings_processed = {}
         for config in configuration_settings:
             if isinstance(config, FeatureFlagConfigurationSetting):

sdk/appconfiguration/azure-appconfiguration-provider/tests/test_async_provider.py

@@ -22,6 +22,7 @@ async def test_provider_creation(self, appconfiguration_connection_string, appco
         ) as client:
             assert client["message"] == "hi"
             assert client["my_json"]["key"] == "value"
+            assert ".appconfig.featureflag/Alpha" not in client
             assert FEATURE_MANAGEMENT_KEY in client
             assert has_feature_flag(client, "Alpha")
 

sdk/appconfiguration/azure-appconfiguration-provider/tests/test_async_provider_aad.py

@@ -22,6 +22,7 @@ async def test_provider_creation_aad(self, appconfiguration_endpoint_string, app
         ) as client:
             assert client.get("message") == "hi"
             assert client["my_json"]["key"] == "value"
+            assert ".appconfig.featureflag/Alpha" not in client
             assert FEATURE_MANAGEMENT_KEY in client
             assert has_feature_flag(client, "Alpha")
 

sdk/appconfiguration/azure-appconfiguration-provider/tests/test_provider.py

@@ -30,6 +30,7 @@ def test_provider_creation(self, appconfiguration_connection_string, appconfigur
         )
         assert client["message"] == "hi"
         assert client["my_json"]["key"] == "value"
+        assert ".appconfig.featureflag/Alpha" not in client
         assert FEATURE_MANAGEMENT_KEY in client
         assert has_feature_flag(client, "Alpha")
 

sdk/appconfiguration/azure-appconfiguration-provider/tests/test_provider_aad.py

@@ -22,6 +22,7 @@ def test_provider_creation_aad(self, appconfiguration_endpoint_string, appconfig
         )
         assert client["message"] == "hi"
         assert client["my_json"]["key"] == "value"
+        assert ".appconfig.featureflag/Alpha" not in client
         assert FEATURE_MANAGEMENT_KEY in client
         assert has_feature_flag(client, "Alpha")