Skip to content

Commit 12dae4f

Browse files
committed
Address comments and fix test
1 parent d967f53 commit 12dae4f

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/Constants.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ final class Constants {
3030
public static final String TOKEN_HASH_CLAIM = "token_sha256_to_refresh";
3131
public static final String CLIENT_CAPABILITY_REQUEST_PARAM = "xms_cc";
3232

33-
// Only Service Fabric and App Service managed identity environments support token revocation
33+
// Only Service Fabric managed identity environments support token revocation
3434
public static final Set<ManagedIdentitySourceType> TOKEN_REVOCATION_SUPPORTED_ENVIRONMENTS = new HashSet<ManagedIdentitySourceType>() {{
3535
add(ManagedIdentitySourceType.SERVICE_FABRIC);
3636
}};

msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/StringHelper.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ static private String createSha256Hash(String stringToHash, boolean base64Encode
4949
* @return The SHA-256 hash of the string as a lowercase hex string
5050
* @throws MsalClientException If the SHA-256 algorithm is not available
5151
*/
52-
public static String createSha256HashHexString(String stringToHash) {
52+
static String createSha256HashHexString(String stringToHash) {
5353
if (stringToHash == null || stringToHash.isEmpty()) {
5454
throw new IllegalArgumentException("String to hash cannot be null or empty");
5555
}
@@ -74,7 +74,7 @@ public static String createSha256HashHexString(String stringToHash) {
7474
}
7575
}
7676

77-
public static boolean isNullOrBlank(final String str) {
77+
static boolean isNullOrBlank(final String str) {
7878
return str == null || str.trim().length() == 0;
7979
}
8080
}

msal4j-sdk/src/test/java/com/microsoft/aad/msal4j/ManagedIdentityTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -722,7 +722,7 @@ void managedIdentityTest_WithCapabilitiesOnly(ManagedIdentitySourceType source,
722722
assertNotNull(result.accessToken());
723723
assertEquals(TokenSource.CACHE, result.metadata().tokenSource());
724724

725-
verify(httpClientMock, times(2)).send(any());
725+
verify(httpClientMock, times(1)).send(any());
726726
}
727727

728728
@ParameterizedTest

0 commit comments

Comments
 (0)