PR feedback

Author: Avery-Dunn

msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/DefaultHttpClientManagedIdentity.java

@@ -23,6 +23,10 @@
 import java.security.cert.CertificateException;
 import java.security.cert.X509Certificate;
 
+/** An extension for the default HttpClient which is meant to perform any extra HTTP behavior needed for a managed identity flow.
+ * <p>
+ * Currently the only extra behavior is the Service Fabric flow, where we must add a certificate thumbprint to the HTTP connection.
+ */
 class DefaultHttpClientManagedIdentity extends DefaultHttpClient {
 
     public static final HostnameVerifier ALL_HOSTS_ACCEPT_HOSTNAME_VERIFIER;

msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/ServiceFabricManagedIdentitySource.java

@@ -24,7 +24,6 @@ class ServiceFabricManagedIdentitySource extends AbstractManagedIdentitySource {
     private final String userAssignedId;
 
     //Service Fabric requires a special check for an environment variable containing a certificate thumbprint used for validating requests.
-    //
     //No other flow need this and an app developer may not be aware of it, so it was decided that for the Service Fabric flow we will simply override
     // any HttpClient that may have been set by the app developer with our own client which performs the validation logic.
     private final IHttpClient httpClient = new DefaultHttpClientManagedIdentity(null, null, null, null);
@@ -80,7 +79,7 @@ public ManagedIdentityResponse getManagedIdentityResponse(
                             managedIdentityRequest.getBodyAsString());
 
             response = httpHelper.executeHttpRequest(httpRequest, managedIdentityRequest.requestContext(), serviceBundle.getTelemetryManager(),
-                    new DefaultHttpClientManagedIdentity(null, null, null, null));
+                    httpClient);
         } catch (URISyntaxException e) {
             throw new RuntimeException(e);
         } catch (MsalClientException e) {