Skip to content

Commit a68d5c8

Browse files
committed
Address PR feedback
1 parent 3f04109 commit a68d5c8

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/AbstractApplicationBase.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -326,13 +326,14 @@ public T readTimeoutForDefaultHttpClient(Integer val) {
326326
}
327327

328328
/**
329-
* Disables the library's internal retry logic for HTTP requests. Used alongside
329+
* The library has a number of policies for retrying HTTP calls in different scenarios.
330+
* <p>
331+
* This will disable all internal retry behavior, allowing customized retry behavior via your own implementation of {@link IHttpClient}
330332
*
331-
* @param val timeout value in milliseconds
332333
* @return instance of the Builder on which method was called
333334
*/
334-
public T disableInternalRetries(boolean val) {
335-
disableInternalRetries = val;
335+
public T disableInternalRetries() {
336+
disableInternalRetries = true;
336337
return self();
337338
}
338339

msal4j-sdk/src/test/java/com/microsoft/aad/msal4j/ManagedIdentityTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -601,7 +601,7 @@ void managedIdentityTest_RetriesDisabled(ManagedIdentitySourceType source, Strin
601601
miApp = ManagedIdentityApplication
602602
.builder(ManagedIdentityId.systemAssigned())
603603
.httpClient(httpClientMock)
604-
.disableInternalRetries(true)
604+
.disableInternalRetries()
605605
.build();
606606

607607
//Several specific 4xx and 5xx errors, such as 500, should trigger MSAL's retry logic

0 commit comments

Comments
 (0)