Merge pull request #875 from AzureAD/avdunn/expire-buffer-fix

Correctly set buffer for expired tokens

Author: Avery-Dunn

msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/AcquireTokenSilentSupplier.java

@@ -129,7 +129,7 @@ private boolean shouldRefresh(SilentParameters parameters, AuthenticationResult
         long currTimeStampSec = new Date().getTime() / 1000;
 
         //If the access token is expired or within 5 minutes of becoming expired, refresh it
-        if (!StringHelper.isBlank(cachedResult.accessToken()) && cachedResult.expiresOn() < (currTimeStampSec - ACCESS_TOKEN_EXPIRE_BUFFER_IN_SEC)) {
+        if (!StringHelper.isBlank(cachedResult.accessToken()) && cachedResult.expiresOn() < (currTimeStampSec + ACCESS_TOKEN_EXPIRE_BUFFER_IN_SEC)) {
             setCacheTelemetry(CacheTelemetry.REFRESH_ACCESS_TOKEN_EXPIRED.telemetryValue);
             log.debug("Refreshing access token because it is expired.");
             return true;