fix: added Automatic-Module-Name to MANIFEST.MF #526
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the Automatic-Module-Name entry is not added to the jar's manifest file, Maven issues a warning during the compilation of a project that uses that jar. Maven issues following warning: "Required filename-based automodules detected: [msal4j-1.13.0.jar]. Please don't publish this project to a public artifact repository!" Currently, only a warning is generated. However, this might cause problems in the future, especially when a project embraces the Java Platform Module System (JPMS).
siddhijain
approved these changes
Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the Automatic-Module-Name entry is not added to the jar's
manifest file, Maven issues a warning during the compilation of a
project that uses that jar.
Maven issues following warning:
"Required filename-based automodules detected: [msal4j-1.13.0.jar].
Please don't publish this project to a public artifact repository!"
Currently, only a warning is generated. However, this might cause
problems in the future, especially when a project embraces the
Java Platform Module System (JPMS).
Fixes #525