Skip to content

plugins for GPG signing #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 14, 2022
Merged

plugins for GPG signing #557

merged 6 commits into from
Oct 14, 2022

Conversation

siddhijain
Copy link
Contributor

@siddhijain siddhijain commented Oct 10, 2022

This PR makes following changes -

  1. include dependencies in broker pom to build javadoc and sources jars.
  2. add gitignore to msal4j-broker module.
  3. Added 1 dummy java file to msal4j-broker module for javadoc to successfully run.

@siddhijain siddhijain requested a review from Avery-Dunn October 12, 2022 15:26
<developers>
<developer>
<id>msopentech</id>
<name>Microsoft Open Technologies, Inc.</name>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was mentioned in a comment on your PR for the build script in the interop layer that 'Microsoft Open Technologies, Inc.' seems like a weird thing to put here, and honestly I'm not sure why this is even in our pom.xml for MSAL Java.

The tag is meant to be an optional documentation thing to just describe the developers, and I think we can just remove it from our pom's since it's not really necessary: https://maven.apache.org/pom.html#Developers

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. It is interesting that some of the tags are optional but were giving me errors if not included. I dont remember if developer tag was one of them but to make it work, I just included everything from msal java pom xml. Lets talk and research more on why it was included in the first place before removing them. If they can be removed, we will remove them from both the modules.

@siddhijain siddhijain merged commit f58214f into dev Oct 14, 2022
@siddhijain siddhijain deleted the add-plugins-for-gpg-signing branch January 6, 2023 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants