Skip to content

Remove Lombok #925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2025
Merged

Remove Lombok #925

merged 1 commit into from
Mar 27, 2025

Conversation

Avery-Dunn
Copy link
Collaborator

Finishes the work started in #919 to remove Lombok code generation.

This PR affects a lot more files, but makes the same changes as the previous PR to remove Lombok's annotations:

  • Replace @Getter and @Setter annotations with actual getter/setters
  • Replace @Builder with an inner builder class
  • Replace @NonNull with our own ParameterValidationUtils.validateNotNull()
  • Move Javadoc comments from the private fields to the public builder methods

The RevAPI plugin was used alongside normal testing to help ensure there are no breaking changes.

@Avery-Dunn Avery-Dunn requested a review from a team as a code owner March 20, 2025 00:15
@Avery-Dunn Avery-Dunn merged commit 3699125 into dev Mar 27, 2025
5 checks passed
@Avery-Dunn Avery-Dunn deleted the avdunn/lombok-removal branch June 3, 2025 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant