Refactor throttling and add it to Managed Identity

Author: rayluo

msal/managed_identity.py

@@ -10,7 +10,8 @@
 from urllib.parse import urlparse  # Python 3+
 from collections import UserDict  # Python 3+
 from .token_cache import TokenCache
-from .throttled_http_client import ThrottledHttpClient
+from .individual_cache import _IndividualCache as IndividualCache
+from .throttled_http_client import ThrottledHttpClientBase, _parse_http_429_5xx_retry_after
 
 
 logger = logging.getLogger(__name__)
@@ -106,6 +107,22 @@ def __init__(self, *, client_id=None, resource_id=None, object_id=None):
                 "client_id, resource_id, object_id")
 
 
+class _ThrottledHttpClient(ThrottledHttpClientBase):
+    def __init__(self, http_client, http_cache):
+        super(_ThrottledHttpClient, self).__init__(http_client, http_cache)
+        self.get = IndividualCache(  # All MIs (except Cloud Shell) use GETs
+            mapping=self._expiring_mapping,
+            key_maker=lambda func, args, kwargs: "POST {} hash={} 429/5xx/Retry-After".format(
+                args[0],  # It is the endpoint, typically a constant per MI type
+                _hash(
+                    # Managed Identity flavors have inconsistent parameters.
+                    # We simply choose to hash them all.
+                    str(kwargs.get("params")) + str(kwargs.get("data"))),
+                ),
+            expires_in=_parse_http_429_5xx_retry_after,
+            )(http_client.get)
+
+
 class ManagedIdentityClient(object):
     """This API encapulates multiple managed identity backends:
     VM, App Service, Azure Automation (Runbooks), Azure Function, Service Fabric,
@@ -115,7 +132,8 @@ class ManagedIdentityClient(object):
     """
     _instance, _tenant = socket.getfqdn(), "managed_identity"  # Placeholders
 
-    def __init__(self, managed_identity, *, http_client, token_cache=None):
+    def __init__(
+        self, managed_identity, *, http_client, token_cache=None, http_cache=None):
         """Create a managed identity client.
 
         :param dict managed_identity:
@@ -141,6 +159,10 @@ def __init__(self, managed_identity, *, http_client, token_cache=None):
             Optional. It accepts a :class:`msal.TokenCache` instance to store tokens.
             It will use an in-memory token cache by default.
 
+        :param http_cache:
+            Optional. It has the same characteristics as the
+            :paramref:`msal.ClientApplication.http_cache`.
+
         Recipe 1: Hard code a managed identity for your app::
 
             import msal, requests
@@ -168,12 +190,21 @@ def __init__(self, managed_identity, *, http_client, token_cache=None):
             token = client.acquire_token_for_client("resource")
         """
         self._managed_identity = managed_identity
-        if isinstance(http_client, ThrottledHttpClient):
-            raise ValueError(
-                # It is a precaution to reject application.py's throttled http_client,
-                # whose cache life on HTTP GET 200 is too long for Managed Identity.
-                "This class does not currently accept a ThrottledHttpClient.")
-        self._http_client = http_client
+        self._http_client = _ThrottledHttpClient(
+            # This class only throttles excess token acquisition requests.
+            # It does not provide retry.
+            # Retry is the http_client or caller's responsibility, not MSAL's.
+            #
+            # FWIW, here is the inconsistent retry recommendation.
+            # 1. Only MI on VM defines exotic 404 and 410 retry recommendations
+            #    ( https://learn.microsoft.com/en-us/entra/identity/managed-identities-azure-resources/how-to-use-vm-token#error-handling )
+            #    (especially for 410 which was supposed to be a permanent failure).
+            # 2. MI on Service Fabric specifically suggests to not retry on 404.
+            #    ( https://learn.microsoft.com/en-us/azure/service-fabric/how-to-managed-cluster-managed-identity-service-fabric-app-code#error-handling )
+            http_client.http_client  # Patch the raw (unpatched) http client
+                if isinstance(http_client, ThrottledHttpClientBase) else http_client,
+            {} if http_cache is None else http_cache,  # Default to an in-memory dict
+        )
         self._token_cache = token_cache or TokenCache()
 
     def acquire_token_for_client(self, *, resource):  # We may support scope in the future

msal/throttled_http_client.py

@@ -45,25 +45,42 @@ def _extract_data(kwargs, key, default=None):
     return data.get(key) if isinstance(data, dict) else default
 
 
-class ThrottledHttpClient(object):
-    def __init__(self, http_client, http_cache):
-        """Throttle the given http_client by storing and retrieving data from cache.
+class ThrottledHttpClientBase(object):
+    """Throttle the given http_client by storing and retrieving data from cache.
 
-        This wrapper exists so that our patching post() and get() would prevent
-        re-patching side effect when/if same http_client being reused.
-        """
-        expiring_mapping = ExpiringMapping(  # It will automatically clean up
+    This wrapper exists so that our patching post() and get() would prevent
+    re-patching side effect when/if same http_client being reused.
+
+    The subclass should implement post() and/or get()
+    """
+    def __init__(self, http_client, http_cache):
+        self.http_client = http_client
+        self._expiring_mapping = ExpiringMapping(  # It will automatically clean up
             mapping=http_cache if http_cache is not None else {},
             capacity=1024,  # To prevent cache blowing up especially for CCA
             lock=Lock(),  # TODO: This should ideally also allow customization
             )
 
+    def post(self, *args, **kwargs):
+        return self.http_client.post(*args, **kwargs)
+
+    def get(self, *args, **kwargs):
+        return self.http_client.get(*args, **kwargs)
+
+    def close(self):
+        return self.http_client.close()
+
+
+class ThrottledHttpClient(ThrottledHttpClientBase):
+    def __init__(self, http_client, http_cache):
+        super(ThrottledHttpClient, self).__init__(http_client, http_cache)
+
         _post = http_client.post  # We'll patch _post, and keep original post() intact
 
         _post = IndividualCache(
             # Internal specs requires throttling on at least token endpoint,
             # here we have a generic patch for POST on all endpoints.
-            mapping=expiring_mapping,
+            mapping=self._expiring_mapping,
             key_maker=lambda func, args, kwargs:
                 "POST {} client_id={} scope={} hash={} 429/5xx/Retry-After".format(
                     args[0],  # It is the url, typically containing authority and tenant
@@ -81,7 +98,7 @@ def __init__(self, http_client, http_cache):
             )(_post)
 
         _post = IndividualCache(  # It covers the "UI required cache"
-            mapping=expiring_mapping,
+            mapping=self._expiring_mapping,
             key_maker=lambda func, args, kwargs: "POST {} hash={} 400".format(
                 args[0],  # It is the url, typically containing authority and tenant
                 _hash(
@@ -120,7 +137,7 @@ def __init__(self, http_client, http_cache):
         self.post = _post
 
         self.get = IndividualCache(  # Typically those discovery GETs
-            mapping=expiring_mapping,
+            mapping=self._expiring_mapping,
             key_maker=lambda func, args, kwargs: "GET {} hash={} 2xx".format(
                 args[0],  # It is the url, sometimes containing inline params
                 _hash(kwargs.get("params", "")),
@@ -129,13 +146,7 @@ def __init__(self, http_client, http_cache):
                 3600*24 if 200 <= result.status_code < 300 else 0,
             )(http_client.get)
 
-        self._http_client = http_client
-
     # The following 2 methods have been defined dynamically by __init__()
     #def post(self, *args, **kwargs): pass
     #def get(self, *args, **kwargs): pass
 
-    def close(self):
-        """MSAL won't need this. But we allow throttled_http_client.close() anyway"""
-        return self._http_client.close()
-