Skip to content

Commit 13dd4a7

Browse files
author
Emmanuel Oche
committed
Fix error check logic and modify test_ccs to include response_mode
1 parent d934c73 commit 13dd4a7

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

msal/oauth2cli/oidc.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -185,8 +185,8 @@ def initiate_auth_code_flow(
185185
# they should simply go with oauth2.Client.
186186
_scope.append("openid")
187187
response_mode = kwargs.get("response_mode")
188-
if response_mode is not None and (response_mode != "form_post" or response_mode != "query"):
189-
raise ValueError('response_mode="form_post" or response_mode="query" is allowed')
188+
if response_mode is not None and response_mode != "form_post" and response_mode != "query":
189+
raise ValueError('only response_mode="form_post" or response_mode="query" is allowed. default is query')
190190
nonce = "".join(random.sample(string.ascii_letters, 16))
191191
flow = super(Client, self).initiate_auth_code_flow(
192192
scope=_scope, nonce=_nonce_hash(nonce), **kwargs)

tests/test_ccs.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ def test_acquire_token_by_auth_code_flow(self):
1616
app = msal.ClientApplication("client_id")
1717
state = "foo"
1818
flow = app.initiate_auth_code_flow(
19-
["some", "scope"], login_hint="[email protected]", state=state)
19+
["some", "scope"], login_hint="[email protected]", state=state, response_mode="form_post")
2020
with patch.object(app.http_client, "post", return_value=MinimalResponse(
2121
status_code=400, text='{"error": "mock"}')) as mocked_method:
2222
app.acquire_token_by_auth_code_flow(flow, {

0 commit comments

Comments
 (0)