Rename enable_broker to allow_broker

Author: rayluo

msal/application.py

@@ -177,7 +177,7 @@ def __init__(
                 # when we would eventually want to add this feature to PCA in future.
             exclude_scopes=None,
             http_cache=None,
-            enable_broker=None,
+            allow_broker=None,
             ):
         """Create an instance of application.
 
@@ -414,7 +414,7 @@ def __init__(
 
             New in version 1.16.0.
 
-        :param boolean enable_broker:
+        :param boolean allow_broker:
             Brokers provide Single-Sign-On, device identification,
             and application identification verification.
             If this parameter is set to True,
@@ -501,9 +501,9 @@ def __init__(
                 raise
         is_confidential_app = bool(
             isinstance(self, ConfidentialClientApplication) or self.client_credential)
-        if is_confidential_app and enable_broker:
-            raise ValueError("enable_broker=True is only supported in PublicClientApplication")
-        self._enable_broker = (enable_broker and not is_confidential_app
+        if is_confidential_app and allow_broker:
+            raise ValueError("allow_broker=True is only supported in PublicClientApplication")
+        self._enable_broker = (allow_broker and not is_confidential_app
             and sys.platform == "win32"
             and not self.authority.is_adfs and not self.authority._is_b2c)
 

tests/msaltest.py

@@ -143,7 +143,7 @@ def main():
             header="Input authority (Note that MSA-PT apps would NOT use the /common authority)",
             accept_nonempty_string=True,
             ),
-        enable_broker=_input_boolean("Enable broker? (Azure CLI currently only supports @microsoft.com accounts when enabling broker)"),
+        allow_broker=_input_boolean("Allow broker? (Azure CLI currently only supports @microsoft.com accounts when enabling broker)"),
         )
     if _input_boolean("Enable MSAL Python's DEBUG log?"):
         logging.basicConfig(level=logging.DEBUG)

tests/test_e2e.py

@@ -155,7 +155,7 @@ def _build_app(cls,
             authority=authority,
             azure_region=azure_region,
             http_client=http_client or MinimalHttpClient(),
-            enable_broker=broker_available  # This way, we reuse same test cases, by run them with and without broker
+            allow_broker=broker_available  # This way, we reuse same test cases, by run them with and without broker
                 and not client_credential,
             )