Skip to content

Commit 5272fbd

Browse files
committed
Might as well refactor a _get_app_metadata()
1 parent 313d721 commit 5272fbd

File tree

2 files changed

+11
-4
lines changed

2 files changed

+11
-4
lines changed

msal/application.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1493,10 +1493,8 @@ def _acquire_token_silent_by_finding_rt_belongs_to_me_or_my_family(
14931493
**kwargs) or last_resp
14941494

14951495
def _get_app_metadata(self, environment):
1496-
apps = self.token_cache.find( # Use find(), rather than token_cache.get(...)
1497-
TokenCache.CredentialType.APP_METADATA, query={
1498-
"environment": environment, "client_id": self.client_id})
1499-
return apps[0] if apps else {}
1496+
return self.token_cache._get_app_metadata(
1497+
environment=environment, client_id=self.client_id, default={})
15001498

15011499
def _acquire_token_silent_by_finding_specific_refresh_token(
15021500
self, authority, scopes, query,

msal/token_cache.py

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -104,6 +104,15 @@ def _get_access_token(
104104
),
105105
default=default)
106106

107+
def _get_app_metadata(self, environment, client_id, default=None): # O(1)
108+
return self._get(
109+
self.CredentialType.APP_METADATA,
110+
self.key_makers[TokenCache.CredentialType.APP_METADATA](
111+
environment=environment,
112+
client_id=client_id,
113+
),
114+
default=default)
115+
107116
def _get(self, credential_type, key, default=None): # O(1)
108117
with self._lock:
109118
return self._cache.get(credential_type, {}).get(key, default)

0 commit comments

Comments
 (0)