Skip to content

Do not add account when performing acquire_token_silent() #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 16, 2020

Conversation

rayluo
Copy link
Collaborator

@rayluo rayluo commented Oct 13, 2020

This will fix #258

@rayluo rayluo requested a review from abhidnya13 October 13, 2020 21:49
@abhidnya13
Copy link
Contributor

Hey Ray, I went through the changes and from what I understand is we skip adding an account in the case of an acquire token silent. So the only place where an account will be added is when we acquire token by rest of the methods.

@abhidnya13 abhidnya13 self-requested a review October 16, 2020 04:47
Copy link
Contributor

@abhidnya13 abhidnya13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! :shipit:

@rayluo rayluo merged commit 93c4c79 into dev Oct 16, 2020
@rayluo rayluo deleted the dont-add-account-when-silent branch October 16, 2020 18:55
@rayluo rayluo mentioned this pull request Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Potential loss of sign-out
2 participants