Skip to content

Fix a malfunction in yesterday's acquire_token_interactive() PR #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 4, 2020

Conversation

rayluo
Copy link
Collaborator

@rayluo rayluo commented Dec 4, 2020

While working on a sample to demonstrate the newly-merged #260, we found a malfunction which prevented acquire_token_interactive() from functioning. So, a follow-up question would be, why the existing test automation did not catch that. Further investigation shows that, our previous test HttpClient was overly-flexible. Now both issues are fixed.

I'll commit the new sample in a different PR (so that it will be cleaner to be referenced).

@rayluo rayluo merged commit 7af214b into dev Dec 4, 2020
@rayluo rayluo deleted the acquire-token-interactive-bugfix branch December 4, 2020 07:13
@rayluo rayluo mentioned this pull request Dec 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant