Skip to content

Update the default broker redirect URI to be a valid URI #673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Update the default broker redirect URI to be a valid URI #673

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions msal/broker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,8 +169,9 @@ def _signin_interactively(
**kwargs):
params = pymsalruntime.MSALRuntimeAuthParameters(client_id, authority)
params.set_requested_scopes(scopes)
params.set_redirect_uri("placeholder") # pymsalruntime 0.1 requires non-empty str,
# the actual redirect_uri will be overridden by a value hardcoded by the broker
params.set_redirect_uri("https://login.microsoftonline.com/common/oauth2/nativeclient")
# This default redirect_uri value is not currently used by the broker
# but it is required by the MSAL.cpp to be set to a non-empty valid URI.
if prompt:
if prompt == "select_account":
if login_hint:
Expand Down