Addressed first iteration comments. Added tests setup for Advisors tests, not possible for recommended actions tests. Finished help documentation for the cmdlets.

Author: Anil Kumar Yelam

src/ResourceManager/Sql/Commands.Sql.Test/ScenarioTests/AdvisorTests.ps1

@@ -12,6 +12,14 @@
 # limitations under the License.
 # ----------------------------------------------------------------------------------
 
+
+# ============================================================
+# A NOTE ON (LACK OF) TEST SETUP FOR RECOMMENDED ACTIONS TESTS
+# ============================================================
+# Recommended actions are generated based on database workload and new database won't get any recommended actions.
+# It's hard to generate mock recommendations on a new server, database or elastic pool from this code as well, as the process is Microsoft Internal.
+# For now, Tests have to use recorded responses on some specific database that already has recommended actions.
+
 <#
 	.SYNOPSIS
 	Tests listing Server recommended actions

src/ResourceManager/Sql/Commands.Sql.Test/ScenarioTests/RecommendedActionTests.ps1

@@ -0,0 +1,38 @@
+// ----------------------------------------------------------------------------------
+//
+// Copyright Microsoft Corporation
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+// http://www.apache.org/licenses/LICENSE-2.0
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+// ----------------------------------------------------------------------------------
+
+
+namespace Microsoft.Azure.Commands.Sql.Advisor.Cmdlet
+{
+    /// <summary>
+    /// Allowed values for updating Advisor Auto-execute Status
+    /// </summary>
+    public enum AdvisorAutoExecuteStatusValues
+    {
+        /// <summary>
+        /// To explicitly enable auto-execute on the current resource for this advisor
+        /// </summary>
+        Enabled,
+
+        /// <summary>
+        /// To explicity disable auto-execute on the current resource for this advisor
+        /// </summary>
+        Disabled,
+
+        /// <summary>
+        /// To clear the explicit value previously set and inherit the default value from the parent of the current resource.
+        /// </summary>
+        Default
+    }
+}

src/ResourceManager/Sql/Commands.Sql.Test/SessionRecords/Microsoft.Azure.Commands.Sql.Test.ScenarioTests.AdvisorTests/TestGetDatabaseAdvisor.json

@@ -42,7 +42,7 @@ public class SetAzureSqlDatabaseAdvisorAutoExecuteStatus : AzureSqlDatabaseAdvis
             ValueFromPipelineByPropertyName = true,
             HelpMessage = "The new auto-execute status of Azure SQL Database Advisor.")]
         [ValidateNotNullOrEmpty]
-        public string AutoExecuteStatus { get; set; }
+        public AdvisorAutoExecuteStatusValues AutoExecuteStatus { get; set; }
 
         /// <summary>
         /// Gets entities from the service.
@@ -69,7 +69,7 @@ protected override IEnumerable<AzureSqlDatabaseAdvisorModel> ApplyUserInputToMod
                 ServerName = ServerName,
                 DatabaseName = DatabaseName,
                 AdvisorName = AdvisorName,
-                AutoExecuteStatus = AutoExecuteStatus
+                AutoExecuteStatus = AutoExecuteStatus.ToString()
             });
 
             return newEntity;

src/ResourceManager/Sql/Commands.Sql.Test/SessionRecords/Microsoft.Azure.Commands.Sql.Test.ScenarioTests.AdvisorTests/TestGetElasticPoolAdvisor.json

@@ -42,7 +42,7 @@ public class SetAzureSqlElasticPoolAdvisorAutoExecuteStatus : AzureSqlElasticPoo
             ValueFromPipelineByPropertyName = true,
             HelpMessage = "The new auto-execute status of Azure SQL Elastic Pool Advisor.")]
         [ValidateNotNullOrEmpty]
-        public string AutoExecuteStatus { get; set; }
+        public AdvisorAutoExecuteStatusValues AutoExecuteStatus { get; set; }
 
         /// <summary>
         /// Gets entities from the service.
@@ -69,7 +69,7 @@ protected override IEnumerable<AzureSqlElasticPoolAdvisorModel> ApplyUserInputTo
                 ServerName = ServerName,
                 ElasticPoolName = ElasticPoolName,
                 AdvisorName = AdvisorName,
-                AutoExecuteStatus = AutoExecuteStatus
+                AutoExecuteStatus = AutoExecuteStatus.ToString()
             });
 
             return newEntity;

src/ResourceManager/Sql/Commands.Sql.Test/SessionRecords/Microsoft.Azure.Commands.Sql.Test.ScenarioTests.AdvisorTests/TestGetServerAdvisor.json

@@ -42,7 +42,7 @@ public class SetAzureSqlServerAdvisorAutoExecuteStatus : AzureSqlServerAdvisorCm
             ValueFromPipelineByPropertyName = true,
             HelpMessage = "The new auto-execute status of Azure SQL Server Advisor.")]
         [ValidateNotNullOrEmpty]
-        public string AutoExecuteStatus { get; set; }
+        public AdvisorAutoExecuteStatusValues AutoExecuteStatus { get; set; }
 
         /// <summary>
         /// Gets entities from the service.
@@ -68,7 +68,7 @@ protected override IEnumerable<AzureSqlServerAdvisorModel> ApplyUserInputToModel
                 ResourceGroupName = ResourceGroupName,
                 ServerName = ServerName,
                 AdvisorName = AdvisorName,
-                AutoExecuteStatus = AutoExecuteStatus
+                AutoExecuteStatus = AutoExecuteStatus.ToString()
             });
 
             return newEntity;

src/ResourceManager/Sql/Commands.Sql.Test/SessionRecords/Microsoft.Azure.Commands.Sql.Test.ScenarioTests.AdvisorTests/TestListDatabaseAdvisors.json

@@ -69,6 +69,7 @@ protected SqlManagementClient GetCurrentSqlClient(string clientRequestId)
             {
                 SqlClient = AzureSession.ClientFactory.CreateClient<SqlManagementClient>(Context, AzureEnvironment.Endpoint.ResourceManager);
             }
+
             SqlClient.HttpClient.DefaultRequestHeaders.Remove(Constants.ClientRequestIdHeaderName);
             SqlClient.HttpClient.DefaultRequestHeaders.Add(Constants.ClientRequestIdHeaderName, clientRequestId);
             return SqlClient;

src/ResourceManager/Sql/Commands.Sql.Test/SessionRecords/Microsoft.Azure.Commands.Sql.Test.ScenarioTests.AdvisorTests/TestListDatabaseAdvisorsExpanded.json

@@ -51,12 +51,14 @@
     <Prefer32Bit>false</Prefer32Bit>
   </PropertyGroup>
   <ItemGroup>
+    <Compile Include="Advisor\Cmdlet\AdvisorAutoExecuteStatusValues.cs" />
     <Compile Include="RecommendedAction\Cmdlet\AzureSqlDatabaseRecommendedActionCmdletBase.cs" />
     <Compile Include="RecommendedAction\Cmdlet\AzureSqlElasticPoolRecommendedActionCmdletBase.cs" />
     <Compile Include="RecommendedAction\Cmdlet\AzureSqlServerRecommendedActionCmdletBase.cs" />
     <Compile Include="RecommendedAction\Cmdlet\GetAzureSqlDatabaseRecommendedActions.cs" />
     <Compile Include="RecommendedAction\Cmdlet\GetAzureSqlElasticPoolRecommendedActions.cs" />
     <Compile Include="RecommendedAction\Cmdlet\GetAzureSqlServerRecommendedActions.cs" />
+    <Compile Include="RecommendedAction\Cmdlet\RecommendedActionStateValues.cs" />
     <Compile Include="RecommendedAction\Cmdlet\SetAzureSqlDatabaseRecommendedActionState.cs" />
     <Compile Include="RecommendedAction\Cmdlet\SetAzureSqlElasticPoolRecommendedActionState.cs" />
     <Compile Include="RecommendedAction\Cmdlet\SetAzureSqlServerRecommendedActionState.cs" />
@@ -354,7 +356,7 @@
     </Reference>
     <Reference Include="Microsoft.Azure.Management.Sql, Version=0.9.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
       <SpecificVersion>False</SpecificVersion>
-      <HintPath>..\..\..\packages\Microsoft.Azure.Management.Sql.0.49.0-prerelease\lib\net40\Microsoft.Azure.Management.Sql.dll</HintPath>
+      <HintPath>G:\GitHub2\azure-powershell\src\packages\Microsoft.Azure.Management.Sql.0.49.0-prerelease\lib\net40\Microsoft.Azure.Management.Sql.dll</HintPath>
       <Private>True</Private>
     </Reference>
     <Reference Include="Microsoft.Azure.Management.Storage">