Comments and class resources cleanup

Author: markcowl

src/ResourceManager/Profile/Commands.Profile/Account/AddAzureRmAccount.cs

@@ -103,7 +103,7 @@ protected override void ProcessRecord()
             {
                 if (string.IsNullOrWhiteSpace(AccountId) )
                 {
-                    throw new PSInvalidOperationException("Access token credentials must contain AccountId parameter.");
+                    throw new PSInvalidOperationException(Resources.AccountIdRequired);
                 }
 
                 azureAccount.Type = AzureAccount.AccountType.AccessToken;
@@ -138,7 +138,8 @@ protected override void ProcessRecord()
 
             var profileClient = new RMProfileClient(AzureRmProfileProvider.Instance.Profile);
 
-            WriteObject((PSAzureProfile)profileClient.Login(azureAccount, Environment, Tenant, SubscriptionId, SubscriptionName, password));
+            WriteObject((PSAzureProfile)profileClient.Login(azureAccount, Environment, Tenant, SubscriptionId, 
+                SubscriptionName, password));
         }
 
         /// <summary>

src/ResourceManager/Profile/Commands.Profile/Models/RMProfileClient.cs

@@ -45,11 +45,13 @@ public RMProfileClient(AzureRMProfile profile)
             }
         }
 
-        public AzureRMProfile Login(AzureAccount account, AzureEnvironment environment, string tenantId, string subscriptionId, string subscriptionName, SecureString password)
+        public AzureRMProfile Login(AzureAccount account, AzureEnvironment environment, string tenantId, string subscriptionId, 
+            string subscriptionName, SecureString password)
         {
             AzureSubscription newSubscription = null;
             AzureTenant newTenant = null;
-            ShowDialog promptBehavior = (password == null && account.Type != AzureAccount.AccountType.AccessToken) ? ShowDialog.Always : ShowDialog.Never;
+            ShowDialog promptBehavior = (password == null && account.Type != AzureAccount.AccountType.AccessToken) 
+                ? ShowDialog.Always : ShowDialog.Never;
 
             // (tenant and subscription are present) OR
             // (tenant is present and subscription is not provided)

src/ResourceManager/Profile/Commands.Profile/Models/SimpleAccessToken.cs

@@ -13,16 +13,25 @@
 // ----------------------------------------------------------------------------------
 
 using System;
+using Microsoft.Azure.Commands.Profile.Properties;
 using Microsoft.Azure.Common.Authentication;
 using Microsoft.Azure.Common.Authentication.Models;
 
 namespace Microsoft.Azure.Commands.Profile.Models
 {
+    /// <summary>
+    /// Provides access token information for a bearer token
+    /// </summary>
     public class SimpleAccessToken : IAccessToken
     {
         public const string _defaultTokenType = "Bearer";
         private string _tokenType;
 
+        /// <summary>
+        /// Create a new access token from the given account and tenant id
+        /// </summary>
+        /// <param name="account">The account, containign user id, access token information</param>
+        /// <param name="tenantId">The tenant id for the given access token</param>
         public SimpleAccessToken(AzureAccount account, string tenantId)
         {
             if (account == null)
@@ -31,12 +40,12 @@ public SimpleAccessToken(AzureAccount account, string tenantId)
             }
             if (string.IsNullOrWhiteSpace(account.Id))
             {
-                throw new ArgumentOutOfRangeException("account", "AccountId must be provided to use an AccessToken credential.");
+                throw new ArgumentOutOfRangeException("account", Resources.AccessTokenRequiresAccount);
             }
             if (account.Type != AzureAccount.AccountType.AccessToken ||
                 !account.IsPropertySet(AzureAccount.Property.AccessToken))
             {
-                throw new ArgumentException("To create an access token credential, you must provide an access token account");
+                throw new ArgumentException(Resources.TypeNotAccessToken);
             }
             this.UserId = account.Id;
             this._tokenType = _defaultTokenType;

src/ResourceManager/Profile/Commands.Profile/Properties/Resources.Designer.cs

@@ -117,6 +117,12 @@
   <resheader name="writer">
     <value>System.Resources.ResXResourceWriter, System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
   </resheader>
+  <data name="AccessTokenRequiresAccount" xml:space="preserve">
+    <value>AccountId must be provided to use an AccessToken credential.</value>
+  </data>
+  <data name="AccountIdRequired" xml:space="preserve">
+    <value>Access token credentials must provide the AccountId parameter.</value>
+  </data>
   <data name="AzureProfileMustNotBeNull" xml:space="preserve">
     <value>Selected profile must not be null.</value>
   </data>
@@ -141,4 +147,7 @@
   <data name="TenantAuthFailed" xml:space="preserve">
     <value>Could not authenticate with tenant {0}. Please ensure that your account has access to this tenant and log in with Login-AzureRmAccount</value>
   </data>
+  <data name="TypeNotAccessToken" xml:space="preserve">
+    <value>To create an access token credential, you must provide an access token account.</value>
+  </data>
 </root>