Skip to content

Commit 3b39092

Browse files
author
Ed Munoz
committed
Add test for the bug fix.
1 parent b5abc36 commit 3b39092

File tree

4 files changed

+28
-2
lines changed

4 files changed

+28
-2
lines changed

src/ServiceManagement/Network/Commands.Network.Test/ScenarioTests/NetworkSecurityGroup/Common.ps1

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ Creates a Security Group.
6262
#>
6363
function New-NetworkSecurityGroup
6464
{
65-
param([string] $securityGroupName)
65+
param([string] $securityGroupName, [string] $location = $location)
6666

6767
New-AzureNetworkSecurityGroup -Name $securityGroupName -Location $location -Label $NSGLabel
6868
}

src/ServiceManagement/Network/Commands.Network.Test/ScenarioTests/NetworkSecurityGroup/NSGScenarioTests.cs

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -99,6 +99,14 @@ public void TestRemoveNSGFromSubnet()
9999
this.RunPowerShellTest("Test-RemoveNetworkSecurityGroupFromSubnet");
100100
}
101101

102+
[Fact]
103+
[Trait(Category.Service, Category.Network)]
104+
[Trait(Category.AcceptanceType, Category.CheckIn)]
105+
public void TestSetNSGToSubnetInDiffRegion()
106+
{
107+
this.RunPowerShellTest("Test-SetNetworkSecurityGroupToSubnetInDifferentRegion");
108+
}
109+
102110
#region Test setup
103111
protected void SetupManagementClients()
104112
{

src/ServiceManagement/Network/Commands.Network.Test/ScenarioTests/NetworkSecurityGroup/NetworkSecurityGroupTests.ps1

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -174,6 +174,24 @@ function Test-SetAndGetNetworkSecurityGroupForSubnet
174174
Assert-AreEqual $securityGroupFromSubnet.Name $securityGroupName
175175
}
176176

177+
<#
178+
.SYNOPSIS
179+
Tests Set and Get-AzureNetworkSecurityGroupForSubnet
180+
#>
181+
function Test-SetNetworkSecurityGroupToSubnetInDifferentRegion
182+
{
183+
# Setup
184+
$securityGroupName = Get-SecurityGroupName
185+
$securityRuleName = Get-SecurityRuleName
186+
$securityGroupLocation = $locations[1].Name
187+
$createdSecurityGroup = New-NetworkSecurityGroup $securityGroupName $securityGroupLocation
188+
Set-AzureVNetConfig ($(Get-Location).Path + "\TestData\SimpleNetworkConfiguration.xml")
189+
190+
# Assert
191+
$expectedMessage = "BadRequest : The region europewest specified for the Network Security Group $securityGroupName is different than the region europenorth that Virtual Network $VirtualNetworkName belongs to, they need to belong to the same region."
192+
Assert-Throws { Set-AzureNetworkSecurityGroupToSubnet -Name $securityGroupName -VirtualNetwork $VirtualNetworkName -Subnet $SubnetName -Force } $expectedMessage
193+
}
194+
177195
########################## Remove Network Security Group for Subnet Tests #############################
178196

179197
<#

src/ServiceManagement/Network/Commands.Network.Test/TestData/SimpleNetworkConfiguration.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
<DnsServers />
77
</Dns>
88
<VirtualNetworkSites>
9-
<VirtualNetworkSite name="VirtualNetworkSiteName" Location="North Central US">
9+
<VirtualNetworkSite name="VirtualNetworkSiteName" Location="North Europe">
1010
<AddressSpace>
1111
<AddressPrefix>192.168.100.0/24</AddressPrefix>
1212
</AddressSpace>

0 commit comments

Comments
 (0)