Merge pull request #24 from AzCiS/data0-iscsi-fix

Fix enableiscsibug in New-ASSConfig and add validation for first time se...

Author: avirupch

src/ServiceManagement/StorSimple/Commands.StorSimple/Cmdlets/DeviceDetails/NewAzureStorSimpleNetworkConfig.cs

@@ -178,11 +178,11 @@ private bool ProcessParameters(){
                 return false;
             }
 
-            // Only EnableCloud, Controller0 and controller1 IP Addresses can be set on Data0
+            // Only EnableIscsi, Controller0 and controller1 IP Addresses can be set on Data0
             if (InterfaceAlias == NetInterfaceId.Data0.ToString())
             {
                 if(IPv4Address != null || IPv4Gateway != null || IPv4Netmask != null
-                    && IPv6Gateway != null || IPv6Prefix != null || EnableIscsi != null)
+                    && IPv6Gateway != null || IPv6Prefix != null || EnableCloud != null)
                 {
                     WriteVerbose(Resources.NetworkConfigData0AllowedSettings);
                     return false;

src/ServiceManagement/StorSimple/Commands.StorSimple/Properties/Resources.Designer.cs

@@ -427,7 +427,7 @@
     <value>IP Address information (IPv4Address and IPv4Netmask or IPv6Prefix)  must be provided for {0} network interface, since it is being enabled</value>
   </data>
   <data name="MandatoryParamsMissingForInitialDeviceConfiguration" xml:space="preserve">
-    <value>Data0 configuration with Controller0 and Controller1 IP Addresses along with TimeZone and Primary DNS Server information is mandatory when configuring the device for the first time</value>
+    <value>Data0 configuration with Controller0 and Controller1 IP Addresses along with TimeZone, Secondary DNS Server information and atleast 1 IscsiEnabled network interface is mandatory when configuring the device for the first time.</value>
   </data>
   <data name="DeviceJobsNextPageFormatMessage" xml:space="preserve">
     <value>More jobs are available for your query. To access the next page of your result use -First {0} -Skip {1} in your commandlet</value>

src/ServiceManagement/StorSimple/Commands.StorSimple/Properties/Resources.resx

@@ -486,6 +486,14 @@ internal bool ValidParamsForFirstDeviceConfiguration(NetworkConfig[] netConfigs,
             {
                 return false;
             }
+
+            // There must be atleast one iscsi enabled net interface in the first config
+            var iscsiEnabledInterfacePresent = netConfigs.Any(x => x.IsIscsiEnabled == true);
+            if (!iscsiEnabledInterfacePresent)
+            {
+                return false;
+            }
+
             return true;
         }