Skip to content

Commit 4fea9bb

Browse files
committed
Merge pull request Azure#1274 from seanbamsft/dev
Update Key Vault manual tests to handle Azure PowerShell 1.0 changes
2 parents a91c23a + 67f429c commit 4fea9bb

File tree

4 files changed

+19
-28
lines changed

4 files changed

+19
-28
lines changed

src/ResourceManager/KeyVault/Commands.KeyVault.Test/Scripts/PSHCommon/Common.ps1

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -250,15 +250,6 @@ function Test-BinaryFile
250250
}
251251

252252

253-
<#
254-
.SYNOPSIS
255-
Removes all current subscriptions.
256-
#>
257-
function Remove-AllSubscriptions
258-
{
259-
Get-AzureRmSubscription | Remove-AzureRmSubscription -Force
260-
}
261-
262253
<#
263254
.SYNOPSIS
264255
Waits on the specified job with the given timeout.

src/ResourceManager/KeyVault/Commands.KeyVault.Test/Scripts/VaultManagementTests.ps1

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ function Test_DeleteUnknownVaultFails
9797
#------------------------------Set-AzureRmKeyVaultAccessPolicy--------------------------
9898
function Test_SetRemoveAccessPolicyByUPN
9999
{
100-
$user = (Get-AzureRmSubscription -Current).DefaultAccount
100+
$user = (Get-AzureRmContext).Account.Id
101101
Reset-PreCreatedVault
102102
Test-SetRemoveAccessPolicyByUPN $global:precreatedVaultName $global:resourceGroupName $user
103103
}
@@ -125,23 +125,23 @@ function Test_SetRemoveAccessPolicyBySPN
125125

126126
function Test_SetRemoveAccessPolicyByObjectId
127127
{
128-
$user = (Get-AzureRmSubscription -Current).DefaultAccount
128+
$user = (Get-AzureRmContext).Account.Id
129129
Reset-PreCreatedVault
130130
Test-SetRemoveAccessPolicyByObjectId $global:precreatedVaultName $global:resourceGroupName $user
131131
}
132132

133133

134134
function Test_SetRemoveAccessPolicyByCompoundId
135135
{
136-
$user = (Get-AzureRmSubscription -Current).DefaultAccount
136+
$user = (Get-AzureRmContext).Account.Id
137137
$appId = [System.Guid]::NewGuid()
138138
Reset-PreCreatedVault
139139
Test-SetRemoveAccessPolicyByCompoundId $global:precreatedVaultName $global:resourceGroupName $user $appId
140140
}
141141

142142
function Test_RemoveAccessPolicyWithCompoundIdPolicies
143143
{
144-
$user = (Get-AzureRmSubscription -Current).DefaultAccount
144+
$user = (Get-AzureRmContext).Account.Id
145145
$appId1 = [System.Guid]::NewGuid()
146146
$appId2 = [System.Guid]::NewGuid()
147147
Reset-PreCreatedVault
@@ -150,51 +150,51 @@ function Test_RemoveAccessPolicyWithCompoundIdPolicies
150150

151151
function Test_SetCompoundIdAccessPolicy
152152
{
153-
$user = (Get-AzureRmSubscription -Current).DefaultAccount
153+
$user = (Get-AzureRmContext).Account.Id
154154
$appId = [System.Guid]::NewGuid()
155155
Reset-PreCreatedVault
156156
Test-SetCompoundIdAccessPolicy $global:precreatedVaultName $global:resourceGroupName $user $appId
157157
}
158158

159159
function Test_ModifyAccessPolicy
160160
{
161-
$user = (Get-AzureRmSubscription -Current).DefaultAccount
161+
$user = (Get-AzureRmContext).Account.Id
162162
Reset-PreCreatedVault
163163
Test-ModifyAccessPolicy $global:precreatedVaultName $global:resourceGroupName $user
164164
}
165165

166166
function Test_ModifyAccessPolicyEnabledForDeployment
167167
{
168-
$user = (Get-AzureRmSubscription -Current).DefaultAccount
168+
$user = (Get-AzureRmContext).Account.Id
169169
Reset-PreCreatedVault
170170
Test-ModifyAccessPolicyEnabledForDeployment $global:precreatedVaultName $global:resourceGroupName $user
171171
}
172172

173173
function Test_ModifyAccessPolicyEnabledForTemplateDeployment
174174
{
175-
$user = (Get-AzureRmSubscription -Current).DefaultAccount
175+
$user = (Get-AzureRmContext).Account.Id
176176
Reset-PreCreatedVault
177177
Test-ModifyAccessPolicyEnabledForTemplateDeployment $global:precreatedVaultName $global:resourceGroupName $user
178178
}
179179

180180
function Test_ModifyAccessPolicyEnabledForDiskEncryption
181181
{
182-
$user = (Get-AzureRmSubscription -Current).DefaultAccount
182+
$user = (Get-AzureRmContext).Account.Id
183183
Reset-PreCreatedVault
184184
Test-ModifyAccessPolicyEnabledForDiskEncryption $global:precreatedVaultName $global:resourceGroupName $user
185185
}
186186

187187
function Test_ModifyAccessPolicyNegativeCases
188188
{
189-
$user = (Get-AzureRmSubscription -Current).DefaultAccount
189+
$user = (Get-AzureRmContext).Account.Id
190190
Reset-PreCreatedVault
191191
Test-ModifyAccessPolicyNegativeCases $global:precreatedVaultName $global:resourceGroupName $user
192192
}
193193

194194

195195
function Test_RemoveNonExistentAccessPolicyDoesNotThrow
196196
{
197-
$user = (Get-AzureRmSubscription -Current).DefaultAccount
197+
$user = (Get-AzureRmContext).Account.Id
198198
Reset-PreCreatedVault
199199
Test-RemoveNonExistentAccessPolicyDoesNotThrow $global:precreatedVaultName $global:resourceGroupName $user
200200
}
@@ -261,7 +261,7 @@ function Initialize-VaultTest
261261
}
262262
#create a vault using ARM
263263
$vaultName = Get-VaultName $suffix
264-
$tenantId = (Get-AzureRmSubscription -Current).TenantId
264+
$tenantId = (Get-AzureRmContext).Tenant.TenantId
265265
$tagName = "testtag"
266266
$tagValue = "testvalue"
267267
$vaultId = @{
@@ -305,7 +305,7 @@ function Reset-PreCreatedVault
305305
{
306306
$tagName = "testtag"
307307
$tagValue = "testvalue"
308-
$tenantId = (Get-AzureRmSubscription -Current).TenantId
308+
$tenantId = (Get-AzureRmContext).Tenant.TenantId
309309
$vaultProperties = @{
310310
"enabledForDeployment" = $false;
311311
"tenantId" = $tenantId;

src/ResourceManager/KeyVault/Commands.KeyVault/Properties/Resources.Designer.cs

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/ResourceManager/KeyVault/Commands.KeyVault/Properties/Resources.resx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@
118118
<value>System.Resources.ResXResourceWriter, System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
119119
</resheader>
120120
<data name="ADObjectNotFound" xml:space="preserve">
121-
<value>Cannot find the Active Directory object '{0}' in tenant '{1}'. Please make sure that the user or application service principal you are authorizing is registered in the current subscription's Azure Active directory. The TenantID displayed by the cmdlet 'get-AzureRmSubscription -current' is the current subscription's Azure Active directory.</value>
121+
<value>Cannot find the Active Directory object '{0}' in tenant '{1}'. Please make sure that the user or application service principal you are authorizing is registered in the current subscription's Azure Active directory. The TenantID displayed by the cmdlet 'Get-AzureRmContext' is the current subscription's Azure Active directory.</value>
122122
</data>
123123
<data name="BackupKeyFileAlreadyExists" xml:space="preserve">
124124
<value>The backup key file '{0}' already exists.</value>
@@ -139,7 +139,7 @@
139139
<value>Invalid AzureEnvironment.</value>
140140
</data>
141141
<data name="InvalidCurrentSubscription" xml:space="preserve">
142-
<value>No current subscription has been designated. Use Select-AzureRmSubscription -Current &lt;subscriptionName&gt; to set the current subscription.</value>
142+
<value>No current subscription has been designated. Use Set-AzureRmContext -SubscriptionName &lt;subscriptionName&gt; to set the current subscription.</value>
143143
</data>
144144
<data name="InvalidKeyAttributes" xml:space="preserve">
145145
<value>Invalid key attributes</value>
@@ -175,7 +175,7 @@
175175
<value>Invalid secret uri '{0}'.</value>
176176
</data>
177177
<data name="InvalidSelectedSubscription" xml:space="preserve">
178-
<value>No subscription is currently selected. Use Select-Subscription to activate a subscription.</value>
178+
<value>No subscription is currently selected. Use Set-AzureRmContext to activate a subscription.</value>
179179
</data>
180180
<data name="InvalidSubscriptionState" xml:space="preserve">
181181
<value>Your Azure credentials have not been set up or have expired, please run Add-AzureRmAccount to set up your Azure credentials.</value>

0 commit comments

Comments
 (0)