Skip to content

Commit 78b6f4c

Browse files
author
ramyapri
committed
Code review fix - Using boolean flag to suppress ResourceCheck instead of override
1 parent c2cbf8f commit 78b6f4c

File tree

4 files changed

+25
-17
lines changed

4 files changed

+25
-17
lines changed

src/ServiceManagement/StorSimple/Commands.StorSimple/Cmdlets/GetAzureStorSimpleResource.cs

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -31,11 +31,8 @@ public class GetAzureStorSimpleResource : StorSimpleCmdletBase
3131
[ValidateNotNullOrEmpty]
3232
public string ResourceName { get; set; }
3333

34-
protected override void BeginProcessing()
35-
{
36-
//to prevent resource checking in StorSimpleCmdletbase.BeginProcessing()
37-
return;
38-
}
34+
//suppress resource check for this commandlet
35+
public GetAzureStorSimpleResource() : base(false) { }
3936

4037
public override void ExecuteCmdlet()
4138
{

src/ServiceManagement/StorSimple/Commands.StorSimple/Cmdlets/GetAzureStorSimpleResourceContext.cs

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -25,12 +25,8 @@ namespace Microsoft.WindowsAzure.Commands.StorSimple.Cmdlets
2525
[Cmdlet(VerbsCommon.Get, "AzureStorSimpleResourceContext"),OutputType(typeof(StorSimpleResourceContext))]
2626
public class GetAzureStorSimpleResourceContext : StorSimpleCmdletBase
2727
{
28-
protected override void BeginProcessing()
29-
{
30-
//we expliclity override BeginProcessing() so that it doesnt verify resource selection as part of StorSimpleCmdletBase
31-
//class's BeginProcessing method
32-
return;
33-
}
28+
//suppress resource check for this commandlet
29+
public GetAzureStorSimpleResourceContext() : base(false) { }
3430

3531
public override void ExecuteCmdlet()
3632
{

src/ServiceManagement/StorSimple/Commands.StorSimple/Cmdlets/SelectAzureStorSimpleResource.cs

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -35,11 +35,8 @@ public class SelectAzureStorSimpleResource : StorSimpleCmdletBase
3535
[ValidateNotNullOrEmpty]
3636
public string RegistrationKey { get; set; }
3737

38-
protected override void BeginProcessing()
39-
{
40-
//we dont have to verify that resource is selected
41-
return;
42-
}
38+
//suppress resource check for this commandlet
39+
public SelectAzureStorSimpleResource() : base(false) { }
4340

4441
/// <summary>
4542
/// ProcessRecord of the command.

src/ServiceManagement/StorSimple/Commands.StorSimple/StorSimpleCmdletBase.cs

Lines changed: 19 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,23 @@ namespace Microsoft.WindowsAzure.Commands.StorSimple
3131
{
3232
public class StorSimpleCmdletBase : AzurePSCmdlet
3333
{
34+
//this property will determine whether before running the actual commandlet logic, should resource selection be verified
35+
protected bool verifyResourceBeforeCmdletExecute;
36+
37+
/// <summary>
38+
/// default constructor for most commandlets. In this case, Resource check will be verified
39+
/// </summary>
40+
public StorSimpleCmdletBase() : this(true) { }
41+
42+
/// <summary>
43+
/// constructor variant if you want to suppress the resource check for your commandlet
44+
/// </summary>
45+
/// <param name="performResourceCheck"></param>
46+
public StorSimpleCmdletBase(bool performResourceCheck):base()
47+
{
48+
verifyResourceBeforeCmdletExecute = performResourceCheck;
49+
}
50+
3451
private StorSimpleClient storSimpleClient;
3552

3653
internal StorSimpleClient StorSimpleClient
@@ -200,7 +217,8 @@ internal virtual void HandleException(Exception exception)
200217
protected override void BeginProcessing()
201218
{
202219
base.BeginProcessing();
203-
VerifyResourceContext();
220+
if(verifyResourceBeforeCmdletExecute)
221+
VerifyResourceContext();
204222
}
205223
/// <summary>
206224
/// this method verifies that a resource has been selected before this commandlet is executed

0 commit comments

Comments
 (0)