Merge pull request #5 from balukambala/ignite

Fixed dsc bugs

Author: safeermohammed

src/ResourceManager/Automation/Commands.Automation/Cmdlet/ExportAzureAutomationDscNodeReportContent.cs

@@ -46,6 +46,7 @@ public class ExportAzureAutomationDscNodeReportContent : AzureAutomationBaseCmdl
         /// Gets or sets the report id. 
         /// </summary> 
         [Parameter(Mandatory = true, ParameterSetName = AutomationCmdletParameterSets.ByAll, ValueFromPipelineByPropertyName = true, HelpMessage = "The dsc node report id.")]
+        [Alias("Id")]
         public Guid ReportId { get; set; }
 
         /// <summary>

src/ResourceManager/Automation/Commands.Automation/Cmdlet/GetAzureAutomationConfiguration.cs

@@ -31,7 +31,7 @@ public class GetAzureAutomationDscConfiguration : AzureAutomationBaseCmdlet
         /// <summary>
         /// Gets or sets the configuration name.
         /// </summary>
-        [Parameter(ParameterSetName = AutomationCmdletParameterSets.ByConfigurationName, Position = 2, Mandatory = true, ValueFromPipeline = true, HelpMessage = "The configuration name.")]
+        [Parameter(ParameterSetName = AutomationCmdletParameterSets.ByConfigurationName, Position = 2, Mandatory = true, ValueFromPipelineByPropertyName = true, HelpMessage = "The configuration name.")]
         [Alias("ConfigurationName")]
         [ValidateNotNullOrEmpty]
         public string Name { get; set; }

src/ResourceManager/Automation/Commands.Automation/Cmdlet/GetAzureAutomationDscCompilationJobOutput.cs

@@ -38,7 +38,7 @@ public class GetAzureAutomationDscCompilationJobOutput : AzureAutomationBaseCmdl
         public Guid Id { get; set; }
 
         [Parameter(Mandatory = false, ValueFromPipelineByPropertyName = true, HelpMessage = "The stream type.")]
-        [ValidateSet("Warning", "Error", "Debug", "Verbose", "Any")]
+        [ValidateSet("Warning", "Error", "Verbose", "Any", IgnoreCase = true)]
         public CompilationJobStreamType Stream { get; set; }
 
         [Parameter(Mandatory = false, ValueFromPipelineByPropertyName = true, HelpMessage = "Retrieves output created after this time")]

src/ResourceManager/Automation/Commands.Automation/Cmdlet/GetAzureAutomationDscNode.cs

@@ -42,21 +42,21 @@ public class GetAzureAutomationDscNode : AzureAutomationBaseCmdlet
         [Parameter(ParameterSetName = AutomationCmdletParameterSets.ByName, Mandatory = false, HelpMessage = "Filter dsc nodes based on their status.")]
         [Parameter(ParameterSetName = AutomationCmdletParameterSets.ByNodeConfiguration, Mandatory = false, HelpMessage = "Filter dsc nodes based on their status.")]
         [Parameter(ParameterSetName = AutomationCmdletParameterSets.ByAll, Mandatory = false, HelpMessage = "Filter dsc nodes based on their status.")]
-        [ValidateSet("Any", "Compliant", "NotCompliant", "Failed", "Pending", "Received", "Unresponsive", IgnoreCase = true)]
+        [ValidateSet("Compliant", "NotCompliant", "Failed", "Pending", "Received", "Unresponsive", IgnoreCase = true)]
         public DscNodeStatus Status { get; set; } 
 
         /// <summary>
         /// Gets or sets the node name.
         /// </summary>
-        [Parameter(ParameterSetName = AutomationCmdletParameterSets.ByName, Mandatory = true, ValueFromPipeline = true, HelpMessage = "The node name.")]
+        [Parameter(ParameterSetName = AutomationCmdletParameterSets.ByName, Mandatory = true, ValueFromPipelineByPropertyName = true, HelpMessage = "The node name.")]
         [ValidateNotNullOrEmpty]
+        [Alias("NodeName")]
         public string Name { get; set; }
 
         /// <summary>
         /// Gets or sets the nodeconfiguration name.
         /// </summary>
         [Parameter(ParameterSetName = AutomationCmdletParameterSets.ByNodeConfiguration, Mandatory = true, HelpMessage = "Filter dsc nodes based on their node configuration name.")]
-        [ValidateNotNullOrEmpty]
         public string NodeConfigurationName { get; set; }
 
         /// <summary>
@@ -75,9 +75,9 @@ public override void ExecuteCmdlet()
             IEnumerable<DscNode> ret = null;
 
             var nodeStatus = this.Status.ToString();
-            if (nodeStatus.Equals(DscNodeStatus.Any))
+            if (nodeStatus.Equals("0"))
             {
-                nodeStatus = string.Empty;
+                nodeStatus = null;
             }
 
             if (this.ParameterSetName == AutomationCmdletParameterSets.ById)

src/ResourceManager/Automation/Commands.Automation/Cmdlet/GetAzureAutomationDscNodeConfiguration.cs

@@ -40,16 +40,15 @@ public class GetAzureAutomationDscNodeConfiguration : AzureAutomationBaseCmdlet
         /// <summary> 
         /// Gets or sets the runbook name of the job. 
         /// </summary> 
-        [Parameter(ParameterSetName = AutomationCmdletParameterSets.ByConfigurationName, Mandatory = true, HelpMessage = "The configuration name.")]
+        [Parameter(ParameterSetName = AutomationCmdletParameterSets.ByConfigurationName, ValueFromPipelineByPropertyName = true, Mandatory = true, HelpMessage = "The configuration name.")]
         public string ConfigurationName { get; set; }
 
         /// <summary> 
         /// Gets or sets the status of a job. 
         /// </summary> 
         [Parameter(ParameterSetName = AutomationCmdletParameterSets.ByConfigurationName, Mandatory = false, HelpMessage = "Filter node configurations by RollupStatus.")]
-        [Parameter(ParameterSetName = AutomationCmdletParameterSets.ByNodeConfigurationName, Mandatory = false, HelpMessage = "Filter node configurations by RollupStatus.")]
         [Parameter(ParameterSetName = AutomationCmdletParameterSets.ByAll, Mandatory = false, HelpMessage = "Filter node configurations by RollupStatus.")]
-        [ValidateSet("Good", "Bad")]
+        [ValidateSet("Good", "Bad", IgnoreCase = true)]
         public string RollupStatus { get; set; }
 
         /// <summary>
@@ -60,9 +59,8 @@ protected override void AutomationExecuteCmdlet()
         {
             IEnumerable<NodeConfiguration> nodeConfigurations;
 
-            if (this.Name != null && !Guid.Empty.Equals(this.Name))
+            if (this.Name != null)
             {
-                // ByJobId 
                 nodeConfigurations = new List<NodeConfiguration> { this.AutomationClient.GetNodeConfiguration(this.ResourceGroupName, this.AutomationAccountName, this.Name, this.RollupStatus) };
             }
             else if (this.ConfigurationName != null)

src/ResourceManager/Automation/Commands.Automation/Cmdlet/StartAzureAutomationDscCompilationJob.cs

@@ -39,7 +39,7 @@ public class StartAzureAutomationDscCompilationJob : AzureAutomationBaseCmdlet
         /// <summary>
         /// Gets or sets the configuration parameters.
         /// </summary>
-        [Parameter(Mandatory = false, ValueFromPipelineByPropertyName = true, HelpMessage = "The compilation job parameters.")]
+        [Parameter(Mandatory = false, HelpMessage = "The compilation job parameters.")]
         public IDictionary Parameters { get; set; }
 
         /// <summary>