Stop-AzureBatchPoolResize with tests and help

Author: jasper-schneider

src/ResourceManager/Batch/Commands.Batch.Test/Commands.Batch.Test.csproj

@@ -167,6 +167,7 @@
     <Compile Include="Pools\NewBatchPoolCommandTests.cs" />
     <Compile Include="Pools\RemoveBatchPoolCommandTests.cs" />
     <Compile Include="Pools\StartBatchPoolResizeCommandTests.cs" />
+    <Compile Include="Pools\StopBatchPoolResizeCommandTests.cs" />
     <Compile Include="Properties\AssemblyInfo.cs" />
     <Compile Include="ScenarioTests\BatchAccountTests.cs" />
     <Compile Include="ScenarioTests\BatchController.cs" />
@@ -346,6 +347,12 @@
     <None Include="SessionRecords\Microsoft.Azure.Commands.Batch.Test.ScenarioTests.PoolTests\TestResizePoolByPipeline.json">
       <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
     </None>
+    <None Include="SessionRecords\Microsoft.Azure.Commands.Batch.Test.ScenarioTests.PoolTests\TestStopResizePoolByName.json">
+      <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
+    </None>
+    <None Include="SessionRecords\Microsoft.Azure.Commands.Batch.Test.ScenarioTests.PoolTests\TestStopResizePoolByPipeline.json">
+      <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
+    </None>
     <None Include="SessionRecords\Microsoft.Azure.Commands.Batch.Test.ScenarioTests.TaskTests\TestCreateTask.json">
       <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
     </None>

src/ResourceManager/Batch/Commands.Batch.Test/Pools/StopBatchPoolResizeCommandTests.cs

@@ -0,0 +1,75 @@
+// ----------------------------------------------------------------------------------
+//
+// Copyright Microsoft Corporation
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+// http://www.apache.org/licenses/LICENSE-2.0
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+// ----------------------------------------------------------------------------------
+
+using System;
+using Microsoft.Azure.Batch;
+using Microsoft.Azure.Batch.Protocol;
+using Microsoft.WindowsAzure.Commands.ScenarioTest;
+using Moq;
+using System.Collections.Generic;
+using System.Linq;
+using System.Management.Automation;
+using System.Threading.Tasks;
+using Xunit;
+using BatchClient = Microsoft.Azure.Commands.Batch.Models.BatchClient;
+
+namespace Microsoft.Azure.Commands.Batch.Test.Pools
+{
+    public class StopBatchPoolResizeCommandTests
+    {
+        private StopBatchPoolResizeCommand cmdlet;
+        private Mock<BatchClient> batchClientMock;
+        private Mock<ICommandRuntime> commandRuntimeMock;
+
+        public StopBatchPoolResizeCommandTests()
+        {
+            batchClientMock = new Mock<BatchClient>();
+            commandRuntimeMock = new Mock<ICommandRuntime>();
+            cmdlet = new StopBatchPoolResizeCommand()
+            {
+                CommandRuntime = commandRuntimeMock.Object,
+                BatchClient = batchClientMock.Object,
+            };
+        }
+
+        [Fact]
+        [Trait(Category.AcceptanceType, Category.CheckIn)]
+        public void StopPoolResizeParametersTest()
+        {
+            BatchAccountContext context = BatchTestHelpers.CreateBatchContextWithKeys();
+            cmdlet.BatchContext = context;
+            cmdlet.Name = null;
+
+            Assert.Throws<ArgumentNullException>(() => cmdlet.ExecuteCmdlet());
+
+            cmdlet.Name = "testPool";
+
+            // Don't go to the service on a StopPoolResize call
+            YieldInjectionInterceptor interceptor = new YieldInjectionInterceptor((opContext, request) =>
+            {
+                if (request is StopPoolResizeRequest)
+                {
+                    StopPoolResizeResponse response = new StopPoolResizeResponse();
+                    Task<object> task = Task<object>.Factory.StartNew(() => { return response; });
+                    return task;
+                }
+                return null;
+            });
+            cmdlet.AdditionalBehaviors = new List<BatchClientBehavior>() { interceptor };
+
+            // Verify no exceptions when required parameter is set
+            cmdlet.ExecuteCmdlet();
+        }
+    }
+}

src/ResourceManager/Batch/Commands.Batch.Test/ScenarioTests/PoolTests.cs

@@ -270,6 +270,42 @@ public void TestResizePoolByPipeline()
                 TestUtilities.GetCallingClass(),
                 TestUtilities.GetCurrentMethodName());
         }
+
+        [Fact]
+        [Trait(Category.AcceptanceType, Category.CheckIn)]
+        public void TestStopResizePoolByName()
+        {
+            BatchController controller = BatchController.NewInstance;
+            BatchAccountContext context = null;
+            controller.RunPsTestWorkflow(
+                () => { return new string[] { string.Format("Test-StopResizePoolByName '{0}' '{1}'", commonAccountName, testPoolName) }; },
+                () =>
+                {
+                    context = ScenarioTestHelpers.GetBatchAccountContextWithKeys(controller, commonAccountName);
+                    ScenarioTestHelpers.WaitForSteadyPoolAllocation(controller, context, testPoolName);
+                },
+                null,
+                TestUtilities.GetCallingClass(),
+                TestUtilities.GetCurrentMethodName());
+        }
+
+        [Fact]
+        [Trait(Category.AcceptanceType, Category.CheckIn)]
+        public void TestStopResizePoolByPipeline()
+        {
+            BatchController controller = BatchController.NewInstance;
+            BatchAccountContext context = null;
+            controller.RunPsTestWorkflow(
+                () => { return new string[] { string.Format("Test-StopResizePoolByPipeline '{0}' '{1}'", commonAccountName, testPoolName) }; },
+                () =>
+                {
+                    context = ScenarioTestHelpers.GetBatchAccountContextWithKeys(controller, commonAccountName);
+                    ScenarioTestHelpers.WaitForSteadyPoolAllocation(controller, context, testPoolName);
+                },
+                null,
+                TestUtilities.GetCallingClass(),
+                TestUtilities.GetCurrentMethodName());
+        }
     }
 
     // Cmdlets that use the HTTP Recorder interceptor for use with scenario tests
@@ -312,4 +348,14 @@ public override void ExecuteCmdlet()
             base.ExecuteCmdlet();
         }
     }
+
+    [Cmdlet(VerbsLifecycle.Stop, "AzureBatchPoolResize_ST")]
+    public class StopBatchPoolResizeScenarioTestCommand : StopBatchPoolResizeCommand
+    {
+        public override void ExecuteCmdlet()
+        {
+            AdditionalBehaviors = new List<BatchClientBehavior>() { ScenarioTestHelpers.CreateHttpRecordingInterceptor() };
+            base.ExecuteCmdlet();
+        }
+    }
 }

src/ResourceManager/Batch/Commands.Batch.Test/ScenarioTests/PoolTests.ps1

@@ -228,4 +228,50 @@ function Test-ResizePoolByPipeline
 	# Verify the TargetDedicated property was updated
 	$pool = Get-AzureBatchPool_ST -Name $poolName -BatchContext $context
 	Assert-AreEqual $newTargetDedicated $pool.TargetDedicated
+}
+
+<#
+.SYNOPSIS
+Tests stopping a pool resize operation using the pool name
+#>
+function Test-StopResizePoolByName
+{
+	param([string]$accountName, [string]$poolName)
+
+	$context = Get-AzureBatchAccountKeys -Name $accountName
+
+	# Start a resize and then stop it
+	$pool = Get-AzureBatchPool_ST -Name $poolName -BatchContext $context
+	$initialTargetDedicated = $pool.TargetDedicated
+
+	$newTargetDedicated = $initialTargetDedicated + 5
+	Start-AzureBatchPoolResize_ST -Name $poolName -TargetDedicated $newTargetDedicated -BatchContext $context
+	Stop-AzureBatchPoolResize_ST -Name $poolName -BatchContext $context
+
+	# Verify the AllocationState changed to Stopping
+	$pool = Get-AzureBatchPool_ST -Name $poolName -BatchContext $context
+	Assert-AreEqual 'Stopping' $pool.AllocationState
+}
+
+<#
+.SYNOPSIS
+Tests stopping a pool resize operation using the pipeline
+#>
+function Test-StopResizePoolByPipeline
+{
+	param([string]$accountName, [string]$poolName)
+
+	$context = Get-AzureBatchAccountKeys -Name $accountName
+
+	# Start a resize and then stop it
+	$pool = Get-AzureBatchPool_ST -Name $poolName -BatchContext $context
+	$initialTargetDedicated = $pool.TargetDedicated
+
+	$newTargetDedicated = $initialTargetDedicated + 5
+	$pool | Start-AzureBatchPoolResize_ST -TargetDedicated $newTargetDedicated -BatchContext $context
+	$pool | Stop-AzureBatchPoolResize_ST -BatchContext $context
+
+	# Verify the AllocationState changed to Stopping
+	$pool = Get-AzureBatchPool_ST -Name $poolName -BatchContext $context
+	Assert-AreEqual 'Stopping' $pool.AllocationState
 }