incorporating CR comments

Author: avirupch

src/ServiceManagement/StorSimple/Commands.StorSimple/Cmdlets/Failover/StartAzureStorSimpleDeviceFailoverJob.cs

@@ -51,10 +51,12 @@ public override void ExecuteCmdlet()
         {
             try
             {
+                string sourceDeviceIdentifierInMessage = string.IsNullOrEmpty(DeviceName) ? DeviceId : DeviceName;
+                string targetDeviceIdentifierInMessage = string.IsNullOrEmpty(TargetDeviceName) ? TargetDeviceId : TargetDeviceName;
                 ConfirmAction(
                     Force.IsPresent,
-                    string.Format(Resources.StartDeviceFailoverJobWarningMessage, DeviceName, TargetDeviceName),
-                    string.Format(Resources.StartDeviceFailoverJobMessage, DeviceName, TargetDeviceName),
+                    string.Format(Resources.StartDeviceFailoverJobWarningMessage, sourceDeviceIdentifierInMessage, targetDeviceIdentifierInMessage),
+                    string.Format(Resources.StartDeviceFailoverJobMessage, sourceDeviceIdentifierInMessage, targetDeviceIdentifierInMessage),
                     string.Empty,
                     () =>
                     {

src/ServiceManagement/StorSimple/Commands.StorSimple/Properties/Resources.Designer.cs

@@ -438,7 +438,4 @@
   <data name="SuccessMessageSubmitDeviceJob" xml:space="preserve">
     <value>The {0} job is triggered successfully. Please use the command Get-AzureStorSimpleJob -InstanceId {1} for tracking the job's status</value>
   </data>
-  <data name="FailureMessageSubmitDeviceJob" xml:space="preserve">
-    <value>The {0} job failed to submit. </value>
-  </data>
 </root>

src/ServiceManagement/StorSimple/Commands.StorSimple/Properties/Resources.resx

@@ -25,7 +25,7 @@ public partial class StorSimpleClient
     {
         public DataContainerGroupsGetResponse GetFaileoverDataContainerGroups(string deviceId)
         {
-            return this.GetStorSimpleClient().DeviceFailover.ListDCGroups(deviceId, this.GetCustomRequestHeaders());
+            return GetStorSimpleClient().DeviceFailover.ListDCGroups(deviceId, this.GetCustomRequestHeaders());
         }
 
         public JobResponse TriggerFailover(string deviceId, DeviceFailoverRequest drRequest)

src/ServiceManagement/StorSimple/Commands.StorSimple/ServiceClients/StorSimpleDeviceFailoverClient.cs

@@ -94,19 +94,8 @@ internal virtual void HandleAsyncTaskResponse(AzureOperationResponse opResponse,
 
         internal virtual void HandleDeviceJobResponse(JobResponse jobResponse, string operationName)
         {
-            string msg = string.Empty;
-
-            if (jobResponse.StatusCode != HttpStatusCode.Accepted && jobResponse.StatusCode != HttpStatusCode.OK)
-            {
-                msg = string.Format(Resources.FailureMessageSubmitDeviceJob, operationName);
-            }
-
-            else
-            {
-                msg = string.Format(Resources.SuccessMessageSubmitDeviceJob, operationName, jobResponse.JobId);
-                WriteObject(jobResponse.JobId);
-            }
-
+            string msg = string.Format(Resources.SuccessMessageSubmitDeviceJob, operationName, jobResponse.JobId);
+            WriteObject(jobResponse.JobId);
             WriteVerbose(msg);
         }