removing wait for complete for device failover job, and introducing verbose message for getting device job status

Author: avirupch

src/ServiceManagement/StorSimple/Commands.StorSimple/Cmdlets/Failover/StartAzureStorSimpleDeviceFailoverJob.cs

@@ -35,10 +35,7 @@ public class StartAzureStorSimpleDeviceFailoverJob : StorSimpleCmdletBase
         [ValidateNotNullOrEmpty]
         public string TargetDeviceName { get; set; }
 
-        [Parameter(Position = 3, Mandatory = false, HelpMessage = StorSimpleCmdletHelpMessage.HelpMessageWaitTillComplete)]
-        public SwitchParameter WaitForComplete { get; set; }
-
-        [Parameter(Position = 4, Mandatory = false, HelpMessage = StorSimpleCmdletHelpMessage.HelpMessageForce)]
+        [Parameter(Position = 3, Mandatory = false, HelpMessage = StorSimpleCmdletHelpMessage.HelpMessageForce)]
         public SwitchParameter Force { get; set; }
 
         public override void ExecuteCmdlet()
@@ -78,17 +75,8 @@ public override void ExecuteCmdlet()
                             ReturnWorkflowId = true
                         };
 
-                        if (WaitForComplete.IsPresent)
-                        {
-                            var taskstatusInfo = StorSimpleClient.TriggerFailover(deviceId, drRequest);
-                            HandleSyncTaskResponse(taskstatusInfo, "start");
-                        }
-                        else
-                        {
-                            //async scenario
-                            var taskresult = StorSimpleClient.TriggerFailoverAsync(deviceId, drRequest);
-                            HandleAsyncTaskResponse(taskresult, "start");
-                        }
+                        var taskResponse = StorSimpleClient.TriggerFailoverAsync(deviceId, drRequest);
+                        HandleDeviceJobResponse(taskResponse, "start");
                     });
             }
             catch (Exception exception)

src/ServiceManagement/StorSimple/Commands.StorSimple/Properties/Resources.Designer.cs

@@ -126,7 +126,7 @@
   <data name="NoBackupPolicyWithGivenNameFound" xml:space="preserve">
     <value>No backuppolicy with name : {0} found in your device: {1} !</value>
   </data>
-  <data name="FailureMessageSubmitJob" xml:space="preserve">
+  <data name="FailureMessageSubmitTask" xml:space="preserve">
     <value>The {0} task failed to submit. </value>
   </data>
   <data name="NotAllowedErrorDataContainerEncryption" xml:space="preserve">
@@ -192,7 +192,7 @@
   <data name="SuccessMessageSetResourceContext" xml:space="preserve">
     <value>Context set successfully for the given resource name.</value>
   </data>
-  <data name="SuccessMessageSubmitJob" xml:space="preserve">
+  <data name="SuccessMessageSubmitTask" xml:space="preserve">
     <value>The {0} task is submitted successfully. Please use the command Get-AzureStorSimpleTask -InstanceId {1} for tracking the task's status</value>
   </data>
   <data name="InvalidBackupIdParameter" xml:space="preserve">
@@ -435,4 +435,7 @@
   <data name="VolumeContainerGroupNotEligibleForFailoverError" xml:space="preserve">
     <value>Volume Container Group \"{0}\" is not eligible for failover due to the reason: {1}</value>
   </data>
+  <data name="SuccessMessageSubmitDeviceJob" xml:space="preserve">
+    <value>A device job for the {0} task is triggered successfully. Please use the command Get-AzureStorSimpleJob -InstanceId {1} for tracking the job's status</value>
+  </data>
 </root>

src/ServiceManagement/StorSimple/Commands.StorSimple/Properties/Resources.resx

@@ -69,22 +69,51 @@ internal virtual void HandleAsyncTaskResponse(AzureOperationResponse opResponse,
 
             if (opResponse.StatusCode != HttpStatusCode.Accepted && opResponse.StatusCode != HttpStatusCode.OK)
             {
-                msg = string.Format(Resources.FailureMessageSubmitJob, operationName);
+                msg = string.Format(Resources.FailureMessageSubmitTask, operationName);
             }
 
             else
             {
                 if (opResponse.GetType().Equals(typeof(TaskResponse)))
                 {
                     var taskResponse = opResponse as TaskResponse;
-                    msg = string.Format(Resources.SuccessMessageSubmitJob, operationName, taskResponse.TaskId);
+                    msg = string.Format(Resources.SuccessMessageSubmitTask, operationName, taskResponse.TaskId);
                     WriteObject(taskResponse.TaskId);
                 }
 
                 else if (opResponse.GetType().Equals(typeof(GuidTaskResponse)))
                 {
                     var guidTaskResponse = opResponse as GuidTaskResponse;
-                    msg = string.Format(Resources.SuccessMessageSubmitJob, operationName, guidTaskResponse.TaskId);
+                    msg = string.Format(Resources.SuccessMessageSubmitTask, operationName, guidTaskResponse.TaskId);
+                    WriteObject(guidTaskResponse.TaskId);
+                }
+            }
+
+            WriteVerbose(msg);
+        }
+
+        internal virtual void HandleDeviceJobResponse(AzureOperationResponse opResponse, string operationName)
+        {
+            string msg = string.Empty;
+
+            if (opResponse.StatusCode != HttpStatusCode.Accepted && opResponse.StatusCode != HttpStatusCode.OK)
+            {
+                msg = string.Format(Resources.FailureMessageSubmitTask, operationName);
+            }
+
+            else
+            {
+                if (opResponse.GetType().Equals(typeof(TaskResponse)))
+                {
+                    var taskResponse = opResponse as TaskResponse;
+                    msg = string.Format(Resources.SuccessMessageSubmitDeviceJob, operationName, taskResponse.TaskId);
+                    WriteObject(taskResponse.TaskId);
+                }
+
+                else if (opResponse.GetType().Equals(typeof(GuidTaskResponse)))
+                {
+                    var guidTaskResponse = opResponse as GuidTaskResponse;
+                    msg = string.Format(Resources.SuccessMessageSubmitDeviceJob, operationName, guidTaskResponse.TaskId);
                     WriteObject(guidTaskResponse.TaskId);
                 }
             }