Skip to content

Commit e94109e

Browse files
committed
Fixed an issue with the pipeline in New-AzureRmCdnEndpoint
Adjusted tests for better code coverage
1 parent eddd849 commit e94109e

File tree

4 files changed

+9
-9
lines changed

4 files changed

+9
-9
lines changed

src/ResourceManager/Cdn/Commands.Cdn.Test/ScenarioTests/CustomDomainTests.ps1

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -41,22 +41,22 @@ function Test-CustomDomainGetRemoveWithRunningEndpoint
4141
$validateResultbyPiping = Test-AzureRmCdnCustomDomain -CdnEndpoint $endpoint -CustomDomainHostName $hostName
4242
Assert-True{$validateResultbyPiping.CustomDomainValidated}
4343

44-
$createdCustomDomain = New-AzureRmCdnCustomDomain -HostName $hostName -CustomDomainName $customDomainName -EndpointName $endpointName -ProfileName $profileName -ResourceGroupName $resourceGroup.ResourceGroupName
44+
$createdCustomDomain = $endpoint | New-AzureRmCdnCustomDomain -HostName $hostName -CustomDomainName $customDomainName
4545
Assert-AreEqual $customDomainName $createdCustomDomain.Name
4646
Assert-AreEqual $hostName $createdCustomDomain.HostName
4747
Assert-ThrowsContains { New-AzureRmCdnCustomDomain -HostName $hostName -CustomDomainName $customDomainName -EndpointName $endpointName -ProfileName $profileName -ResourceGroupName $resourceGroup.ResourceGroupName } "existing"
4848

49-
$customDomain = Get-AzureRmCdnCustomDomain -CustomDomainName $customDomainName -EndpointName $endpointName -ProfileName $profileName -ResourceGroupName $resourceGroup.ResourceGroupName
49+
$customDomain = $endpoint | Get-AzureRmCdnCustomDomain -CustomDomainName $customDomainName
5050
Assert-AreEqual $customDomainName $customDomain.Name
5151
Assert-AreEqual $hostName $customDomain.HostName
5252

53-
$removed = Remove-AzureRmCdnCustomDomain -CustomDomainName $customDomainName -EndpointName $endpointName -ProfileName $profileName -ResourceGroupName $resourceGroup.ResourceGroupName -PassThru
53+
$removed = $customDomain | Remove-AzureRmCdnCustomDomain -PassThru
5454
Assert-True{$removed}
5555
Assert-ThrowsContains { Remove-AzureRmCdnCustomDomain -CustomDomainName $customDomainName -EndpointName $endpointName -ProfileName $profileName -ResourceGroupName $resourceGroup.ResourceGroupName } "does not exist"
5656

5757
Assert-ThrowsContains { Get-AzureRmCdnCustomDomain -CustomDomainName $customDomainName -EndpointName $endpointName -ProfileName $profileName -ResourceGroupName $resourceGroup.ResourceGroupName } "NotFound"
5858

59-
Remove-AzureRmResourceGroup -Name $resourceGroup.ResourceGroupName -Force
59+
Remove-AzureRmResourceGroup -Name $resourceGroup.ResourceGroupName -Force
6060
}
6161

6262
<#

src/ResourceManager/Cdn/Commands.Cdn.Test/ScenarioTests/EndpointTests.ps1

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -375,8 +375,8 @@ function Test-EndpointPipeline
375375
$originHostName = "www.microsoft.com"
376376

377377

378-
New-AzureRmCdnEndpoint -EndpointName $endpointName1 -ProfileName $profileName -ResourceGroupName $resourceGroup.ResourceGroupName -Location $resourceLocation -OriginName $originName -OriginHostName $originHostName
379-
New-AzureRmCdnEndpoint -EndpointName $endpointName2 -ProfileName $profileName -ResourceGroupName $resourceGroup.ResourceGroupName -Location $resourceLocation -OriginName $originName -OriginHostName $originHostName
378+
$createdProfile | New-AzureRmCdnEndpoint -EndpointName $endpointName1 -OriginName $originName -OriginHostName $originHostName
379+
$createdProfile | New-AzureRmCdnEndpoint -EndpointName $endpointName2 -OriginName $originName -OriginHostName $originHostName
380380

381381
$endpoints = Get-AzureRmCdnProfile -ProfileName $profileName -ResourceGroupName $resourceGroup.ResourceGroupName | Get-AzureRmCdnEndpoint
382382

src/ResourceManager/Cdn/Commands.Cdn.Test/ScenarioTests/OriginTests.ps1

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ function Test-OriginGetSetWithRunningEndpoint
3131

3232
$createdEndpoint = New-AzureRmCdnEndpoint -EndpointName $endpointName -ProfileName $profileName -ResourceGroupName $resourceGroup.ResourceGroupName -Location $resourceLocation -OriginName $originName -OriginHostName $originHostName -HttpPort $httpPort
3333

34-
$createdOrigin = Get-AzureRmCdnOrigin -OriginName $originName -EndpointName $endpointName -ProfileName $profileName -ResourceGroupName $resourceGroup.ResourceGroupName
34+
$createdOrigin = $createdEndpoint | Get-AzureRmCdnOrigin -OriginName $originName
3535
Assert-AreEqual $originName $createdOrigin.Name
3636
Assert-AreEqual $originHostName $createdOrigin.HostName
3737
Assert-AreEqual $httpPort $createdOrigin.HttpPort
@@ -41,7 +41,7 @@ function Test-OriginGetSetWithRunningEndpoint
4141
$createdOrigin.HttpsPort = 456
4242
$createdOrigin.HostName = "www.azure.com"
4343

44-
$updatedOrigin = Set-AzureRmCdnOrigin -CdnOrigin $createdOrigin
44+
$updatedOrigin = $createdOrigin | Set-AzureRmCdnOrigin
4545

4646
Assert-AreEqual $originName $updatedOrigin.Name
4747
Assert-AreEqual "www.azure.com" $updatedOrigin.HostName

src/ResourceManager/Cdn/Commands.Cdn/Endpoint/NewAzureRmCdnEndpoint.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ public class NewAzureRmCdnEndpoint : AzureCdnCmdletBase
3838
[ValidateNotNullOrEmpty]
3939
public string ProfileName { get; set; }
4040

41-
[Parameter(Mandatory = true, HelpMessage = "The resource group of the Azure CDN Profile.", ValueFromPipelineByPropertyName = true, ParameterSetName = FieldsParameterSet)]
41+
[Parameter(Mandatory = true, HelpMessage = "The resource group of the Azure CDN Profile.", ParameterSetName = FieldsParameterSet)]
4242
[ValidateNotNullOrEmpty]
4343
public string ResourceGroupName { get; set; }
4444

0 commit comments

Comments
 (0)