Skip to content

Commit e96d655

Browse files
pankajsnpankajsn
committed
Code review comments fixed [Hovsep]
-Cmdlet name fixed as per naming convention -Assembly version fixed -snk file removed from test -ChangeLog.md file updated
1 parent fbeaf6f commit e96d655

24 files changed

+204
-204
lines changed

‎ChangeLog.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
## 2016.02.02 version 1.1.1
2-
* Azure RemoteApp: Organizational Unit in Azure RemoteApp RDFE cmdlets now accepts Unicode characters.
1+
##2016.03.08 version 1.3.0
32
* Azure LogicApp: New cmdlets for managing LogicApps
43
* Get-AzureLogicAppAccessKey
54
* Get-AzureLogicApp
@@ -13,6 +12,8 @@
1312
* Set-AzureLogicAppAccessKey
1413
* Set-AzureLogicApp
1514
* Stop-AzureLogicAppRun
15+
## 2016.02.02 version 1.1.1
16+
* Azure RemoteApp: Organizational Unit in Azure RemoteApp RDFE cmdlets now accepts Unicode characters.
1617
## 2016.01.12 version 1.1.0
1718
* Azure SQL Database: Threat Detection policies:
1819
* Using new Threat Detection Types

‎src/ResourceManager/LogicApp/AzureRM.LogicApp.psd1

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
@{
1010

1111
# Version number of this module.
12-
ModuleVersion = '0.10.0'
12+
ModuleVersion = '1.0.3'
1313

1414
# ID used to uniquely identify this module
1515
GUID = '8A7D44BB-E747-4265-8F22-B3937961D709'

‎src/ResourceManager/LogicApp/Commands.LogicApp.Test/Commands.LogicApp.Test.csproj

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,6 @@
145145
<Compile Include="UnitTests\LogicAppUnitTestBase.cs" />
146146
</ItemGroup>
147147
<ItemGroup>
148-
<None Include="MSSharedLibKey.snk" />
149148
<None Include="packages.config">
150149
<SubType>Designer</SubType>
151150
</None>

‎src/ResourceManager/LogicApp/Commands.LogicApp.Test/MSSharedLibKey.snk

-160 Bytes
Binary file not shown.

‎src/ResourceManager/LogicApp/Commands.LogicApp.Test/Properties/AssemblyInfo.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,5 +46,5 @@
4646
// You can specify all the values or you can default the Build and Revision Numbers
4747
// by using the '*' as shown below:
4848
// [assembly: AssemblyVersion("1.0.*")]
49-
[assembly: AssemblyVersion(Microsoft.WindowsAzure.Commands.Common.AzurePowerShell.AssemblyVersion)]
50-
[assembly: AssemblyFileVersion(Microsoft.WindowsAzure.Commands.Common.AzurePowerShell.AssemblyFileVersion)]
49+
[assembly: AssemblyVersion("1.0.3")]
50+
[assembly: AssemblyFileVersion("1.0.3")]

‎src/ResourceManager/LogicApp/Commands.LogicApp.Test/ScenarioTests/Common.ps1

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,6 +104,6 @@ function TestSetup-CreateWorkflow ([string]$resourceGroupName, [string]$workflow
104104

105105
$definitionFilePath = "Resources\TestSimpleWorkflowDefinition.json"
106106
$parameterFilePath = "Resources\TestSimpleWorkflowParameter.json"
107-
$workflow = $resourceGroup | New-AzureLogicApp -Name $workflowName -AppServicePlan $AppServicePlan -DefinitionFilePath $definitionFilePath -ParameterFilePath $parameterFilePath
107+
$workflow = $resourceGroup | New-AzureRmLogicApp -Name $workflowName -AppServicePlan $AppServicePlan -DefinitionFilePath $definitionFilePath -ParameterFilePath $parameterFilePath
108108
return $workflow
109109
}

‎src/ResourceManager/LogicApp/Commands.LogicApp.Test/ScenarioTests/WorkflowAccessKeyTests.ps1

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -26,11 +26,11 @@ function Test-GetAzureLogicAppAccessKey
2626
$workflow = TestSetup-CreateWorkflow $resourceGroupName $workflowName $planName
2727

2828
#Case1: Get access keys of the workflow
29-
$workflowAccessKeys = Get-AzureLogicAppAccessKey -ResourceGroupName $resourceGroupName -Name $workflowName
29+
$workflowAccessKeys = Get-AzureRmLogicAppAccessKey -ResourceGroupName $resourceGroupName -Name $workflowName
3030
Assert-NotNull $workflowAccessKeys
3131

3232
#Case2: Get specific access key of the workflow
33-
$workflowAccessKeys = Get-AzureLogicAppAccessKey -ResourceGroupName $resourceGroupName -Name $workflowName -AccessKeyName "default"
33+
$workflowAccessKeys = Get-AzureRmLogicAppAccessKey -ResourceGroupName $resourceGroupName -Name $workflowName -AccessKeyName "default"
3434
Assert-NotNull $workflowAccessKeys
3535
}
3636

@@ -46,9 +46,9 @@ function Test-SetAzureLogicAppAccessKey
4646
$workflow = TestSetup-CreateWorkflow $resourceGroupName $workflowName $planName
4747

4848
#Case1: Regenerate secret for the access key of the workflow
49-
$workflowAccessKeys = Get-AzureLogicAppAccessKey -ResourceGroupName $resourceGroupName -Name $workflowName
50-
$workflowAccessKey1 = Set-AzureLogicAppAccessKey -ResourceGroupName $resourceGroupName -Name $workflowName -AccessKeyName "default" -KeyType "Primary"
51-
$workflowAccessKey2 = Set-AzureLogicAppAccessKey -ResourceGroupName $resourceGroupName -Name $workflowName -AccessKeyName "default" -KeyType "Secondary"
49+
$workflowAccessKeys = Get-AzureRmLogicAppAccessKey -ResourceGroupName $resourceGroupName -Name $workflowName
50+
$workflowAccessKey1 = Set-AzureRmLogicAppAccessKey -ResourceGroupName $resourceGroupName -Name $workflowName -AccessKeyName "default" -KeyType "Primary"
51+
$workflowAccessKey2 = Set-AzureRmLogicAppAccessKey -ResourceGroupName $resourceGroupName -Name $workflowName -AccessKeyName "default" -KeyType "Secondary"
5252

5353
Assert-AreNotEqual $workflowAccessKey1.PrimarySecretKey $workflowAccessKeys.PrimarySecretKey
5454
Assert-AreNotEqual $workflowAccessKey2.SecondarySecretKey $workflowAccessKeys.SecondarySecretKey

‎src/ResourceManager/LogicApp/Commands.LogicApp.Test/ScenarioTests/WorkflowRunTests.ps1

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -26,20 +26,20 @@ function Test-StartLogicApp
2626
$workflowName = getAssetname
2727
$definitionFilePath = "Resources\TestSimpleWorkflowTriggerDefinition.json"
2828

29-
$workflow = New-AzureLogicApp -ResourceGroupName $resourceGroupName -Name $workflowName -DefinitionFilePath $definitionFilePath -AppServicePlan $planName
29+
$workflow = New-AzureRmLogicApp -ResourceGroupName $resourceGroupName -Name $workflowName -DefinitionFilePath $definitionFilePath -AppServicePlan $planName
3030

3131
[int]$counter = 0
3232
do {
3333
Sleep -seconds 2
34-
$workflow = Get-AzureLogicApp -ResourceGroupName $resourceGroupName -Name $workflowName
34+
$workflow = Get-AzureRmLogicApp -ResourceGroupName $resourceGroupName -Name $workflowName
3535
} while ($workflow.State -ne "Enabled" -and $counter++ -lt 5)
3636

37-
Start-AzureLogicApp -ResourceGroupName $resourceGroupName -Name $workflowName -TriggerName "httpTrigger"
37+
Start-AzureRmLogicApp -ResourceGroupName $resourceGroupName -Name $workflowName -TriggerName "httpTrigger"
3838
}
3939

4040
<#
4141
.SYNOPSIS
42-
Test Get-AzureLogicAppRunHistory and Get-AzureLogicAppRun command to get the logic app history
42+
Test Get-AzureRmLogicAppRunHistory and Get-AzureRmLogicAppRun command to get the logic app history
4343
#>
4444
function Test-GetAzureLogicAppRunHistory
4545
{
@@ -51,26 +51,26 @@ function Test-GetAzureLogicAppRunHistory
5151
$workflowName = getAssetname
5252
$definitionFilePath = "Resources\TestSimpleWorkflowTriggerDefinition.json"
5353

54-
$workflow = New-AzureLogicApp -ResourceGroupName $resourceGroupName -Name $workflowName -DefinitionFilePath $definitionFilePath -AppServicePlan $planName
54+
$workflow = New-AzureRmLogicApp -ResourceGroupName $resourceGroupName -Name $workflowName -DefinitionFilePath $definitionFilePath -AppServicePlan $planName
5555

5656
[int]$counter = 0
5757
do {
5858
Sleep -seconds 2
59-
$workflow = Get-AzureLogicApp -ResourceGroupName $resourceGroupName -Name $workflowName
59+
$workflow = Get-AzureRmLogicApp -ResourceGroupName $resourceGroupName -Name $workflowName
6060
} while ($workflow.State -ne "Enabled" -and $counter++ -lt 5)
6161

62-
Start-AzureLogicApp -ResourceGroupName $resourceGroupName -Name $workflowName -TriggerName "httpTrigger"
62+
Start-AzureRmLogicApp -ResourceGroupName $resourceGroupName -Name $workflowName -TriggerName "httpTrigger"
6363

64-
$runHistory = Get-AzureLogicAppRunHistory -ResourceGroupName $resourceGroupName -Name $workflowName
64+
$runHistory = Get-AzureRmLogicAppRunHistory -ResourceGroupName $resourceGroupName -Name $workflowName
6565
Assert-NotNull $runHistory
66-
$run = Get-AzureLogicAppRunHistory -ResourceGroupName $resourceGroupName -Name $workflowName -RunName $runHistory[0].Name
66+
$run = Get-AzureRmLogicAppRunHistory -ResourceGroupName $resourceGroupName -Name $workflowName -RunName $runHistory[0].Name
6767
Assert-NotNull $run
6868
Assert-AreEqual $runHistory[0].Name $run.Name
6969
}
7070

7171
<#
7272
.SYNOPSIS
73-
Test Get-AzureLogicAppRunAction command to get the logic app run action
73+
Test Get-AzureRmLogicAppRunAction command to get the logic app run action
7474
#>
7575
function Test-GetAzureLogicAppRunAction
7676
{
@@ -82,24 +82,24 @@ function Test-GetAzureLogicAppRunAction
8282
$workflowName = getAssetname
8383
$definitionFilePath = "Resources\TestSimpleWorkflowTriggerDefinition.json"
8484

85-
$workflow = New-AzureLogicApp -ResourceGroupName $resourceGroupName -Name $workflowName -DefinitionFilePath $definitionFilePath -AppServicePlan $planName
85+
$workflow = New-AzureRmLogicApp -ResourceGroupName $resourceGroupName -Name $workflowName -DefinitionFilePath $definitionFilePath -AppServicePlan $planName
8686

8787
[int]$counter = 0
8888
do {
8989
Sleep -seconds 2
90-
$workflow = Get-AzureLogicApp -ResourceGroupName $resourceGroupName -Name $workflowName
90+
$workflow = Get-AzureRmLogicApp -ResourceGroupName $resourceGroupName -Name $workflowName
9191
} while ($workflow.State -ne "Enabled" -and $counter++ -lt 5)
9292

93-
Start-AzureLogicApp -ResourceGroupName $resourceGroupName -Name $workflowName -TriggerName "httpTrigger"
93+
Start-AzureRmLogicApp -ResourceGroupName $resourceGroupName -Name $workflowName -TriggerName "httpTrigger"
9494

95-
$runHistory = Get-AzureLogicAppRunHistory -ResourceGroupName $resourceGroupName -Name $workflowName
95+
$runHistory = Get-AzureRmLogicAppRunHistory -ResourceGroupName $resourceGroupName -Name $workflowName
9696
Assert-NotNull $runHistory
9797

98-
$actions = Get-AzureLogicAppRunAction -ResourceGroupName $resourceGroupName -Name $workflowName -RunName $runHistory[0].Name
98+
$actions = Get-AzureRmLogicAppRunAction -ResourceGroupName $resourceGroupName -Name $workflowName -RunName $runHistory[0].Name
9999
Assert-NotNull $actions
100100
Assert-AreEqual 2 $actions.Count
101101

102-
$action = Get-AzureLogicAppRunAction -ResourceGroupName $resourceGroupName -Name $workflowName -RunName $runHistory[0].Name -ActionName "http"
102+
$action = Get-AzureRmLogicAppRunAction -ResourceGroupName $resourceGroupName -Name $workflowName -RunName $runHistory[0].Name -ActionName "http"
103103
Assert-NotNull $action
104104

105105
}

0 commit comments

Comments
 (0)