Allow x and y to be negative values (#362)

Author: PolygonalSun

Modules/@babylonjs/react-native-windows/windows/BabylonReactNative/EngineView.cpp

@@ -64,8 +64,8 @@ namespace winrt::BabylonReactNative::implementation {
         const auto properties = point.Properties();
         const auto deviceType = point.PointerDevice().PointerDeviceType();
         const auto position = point.Position();
-        const uint32_t x = position.X < 0 ? 0 : static_cast<uint32_t>(position.X);
-        const uint32_t y = position.Y < 0 ? 0 : static_cast<uint32_t>(position.Y);
+        const int32_t x = static_cast<int32_t>(position.X);
+        const int32_t y = static_cast<int32_t>(position.Y);
         const auto pointerId = point.PointerId();
 
         if (!_inputSource.HasCapture())
@@ -106,8 +106,8 @@ namespace winrt::BabylonReactNative::implementation {
         const auto point = args.CurrentPoint();
         const auto deviceType = point.PointerDevice().PointerDeviceType();
         const auto position = point.Position();
-        const uint32_t x = position.X < 0 ? 0 : static_cast<uint32_t>(position.X);
-        const uint32_t y = position.Y < 0 ? 0 : static_cast<uint32_t>(position.Y);
+        const int32_t x = static_cast<int32_t>(position.X);
+        const int32_t y = static_cast<int32_t>(position.Y);
 
         if (deviceType == PointerDeviceType::Mouse)
         {
@@ -126,8 +126,8 @@ namespace winrt::BabylonReactNative::implementation {
         const auto properties = point.Properties();
         const auto deviceType = point.PointerDevice().PointerDeviceType();
         const auto position = point.Position();
-        const uint32_t x = position.X < 0 ? 0 : static_cast<uint32_t>(position.X);
-        const uint32_t y = position.Y < 0 ? 0 : static_cast<uint32_t>(position.Y);
+        const int32_t x = static_cast<int32_t>(position.X);
+        const int32_t y = static_cast<int32_t>(position.Y);
         const auto pointerId = point.PointerId();
 
         _pressedPointers.erase(pointerId);

Modules/@babylonjs/react-native/shared/BabylonNative.cpp

@@ -136,7 +136,7 @@ namespace BabylonNative
             m_isRenderingEnabled = false;
         }
 
-        void SetMouseButtonState(uint32_t buttonId, bool isDown, uint32_t x, uint32_t y)
+        void SetMouseButtonState(uint32_t buttonId, bool isDown, int32_t x, int32_t y)
         {
             if (isDown)
             {
@@ -148,12 +148,12 @@ namespace BabylonNative
             }
         }
 
-        void SetMousePosition(uint32_t x, uint32_t y)
+        void SetMousePosition(int32_t x, int32_t y)
         {
             m_nativeInput->MouseMove(x, y);
         }
 
-        void SetTouchButtonState(uint32_t pointerId, bool isDown, uint32_t x, uint32_t y)
+        void SetTouchButtonState(uint32_t pointerId, bool isDown, int32_t x, int32_t y)
         {
             if (isDown)
             {
@@ -165,7 +165,7 @@ namespace BabylonNative
             }
         }
 
-        void SetTouchPosition(uint32_t pointerId, uint32_t x, uint32_t y)
+        void SetTouchPosition(uint32_t pointerId, int32_t x, int32_t y)
         {
             m_nativeInput->TouchMove(pointerId, x, y);
         }
@@ -281,31 +281,31 @@ namespace BabylonNative
         }
     }
 
-    void SetMouseButtonState(uint32_t buttonId, bool isDown, uint32_t x, uint32_t y)
+    void SetMouseButtonState(uint32_t buttonId, bool isDown, int32_t x, int32_t y)
     {
         if (auto nativeModule{ g_nativeModule.lock() })
         {
             nativeModule->SetMouseButtonState(buttonId, isDown, x, y);
         }
     }
 
-    void SetMousePosition(uint32_t x, uint32_t y)
+    void SetMousePosition(int32_t x, int32_t y)
     {
         if (auto nativeModule{ g_nativeModule.lock() })
         {
             nativeModule->SetMousePosition(x, y);
         }
     }
 
-    void SetTouchButtonState(uint32_t pointerId, bool isDown, uint32_t x, uint32_t y)
+    void SetTouchButtonState(uint32_t pointerId, bool isDown, int32_t x, int32_t y)
     {
         if (auto nativeModule{ g_nativeModule.lock() })
         {
             nativeModule->SetTouchButtonState(pointerId, isDown, x, y);
         }
     }
 
-    void SetTouchPosition(uint32_t pointerId, uint32_t x, uint32_t y)
+    void SetTouchPosition(uint32_t pointerId, int32_t x, int32_t y)
     {
         if (auto nativeModule{ g_nativeModule.lock() })
         {

Modules/@babylonjs/react-native/shared/BabylonNative.h

@@ -31,10 +31,10 @@ namespace BabylonNative
 
     void RenderView();
     void ResetView();
-    void SetMouseButtonState(uint32_t buttonId, bool isDown, uint32_t x, uint32_t y);
-    void SetMousePosition(uint32_t x, uint32_t y);
-    void SetTouchButtonState(uint32_t pointerId, bool isDown, uint32_t x, uint32_t y);
-    void SetTouchPosition(uint32_t pointerId, uint32_t x, uint32_t y);
+    void SetMouseButtonState(uint32_t buttonId, bool isDown, int32_t x, int32_t y);
+    void SetMousePosition(int32_t x, int32_t y);
+    void SetTouchButtonState(uint32_t pointerId, bool isDown, int32_t x, int32_t y);
+    void SetTouchPosition(uint32_t pointerId, int32_t x, int32_t y);
 
     bool IsXRActive();