Merge pull request #546 from yadavan88/repo-cleanup

Fixed many of the warnings after scala 2.13 upgrade

Author: lor6

build.sbt

@@ -134,12 +134,13 @@ lazy val scala_core_collections = (project in file("scala-core-collections"))
     )
   )
 
-lazy val scala_core_collections_2 = (project in file("scala-core-collections-2"))
-  .settings(
-    name := "scala-core-collections-2",
-    libraryDependencies +=
-      "org.scalatest" %% "scalatest" % "3.2.14" % Test
-  )
+lazy val scala_core_collections_2 =
+  (project in file("scala-core-collections-2"))
+    .settings(
+      name := "scala-core-collections-2",
+      libraryDependencies +=
+        "org.scalatest" %% "scalatest" % "3.2.14" % Test
+    )
 
 lazy val scala_test = (project in file("scala-test"))
   .settings(
@@ -186,7 +187,6 @@ lazy val scala_akka_2 = (project in file("scala-akka-2"))
   .enablePlugins(AkkaGrpcPlugin)
   .settings(
     name := "scala-akka-2",
-    scalaVersion := "2.13.10",
     libraryDependencies ++= Seq(
       "com.typesafe.akka" %% "akka-actor-typed" % "2.6.19",
       "com.typesafe.akka" %% "akka-http" % "10.2.10",
@@ -235,9 +235,11 @@ val monixVersion = "3.4.0"
 val elastic4sVersion = "7.16.0"
 val sparkVersion = "3.2.1"
 
+val sparkCoreDep = "org.apache.spark" %% "spark-core" % sparkVersion
+val sparkSqlDep = "org.apache.spark" %% "spark-sql" % sparkVersion
+
 lazy val scala_libraries_2 = (project in file("scala-libraries-2"))
   .settings(
-    scalaVersion := "2.12.15",
     name := "scala-libraries",
     libraryDependencies += "org.scalatest" %% "scalatest" % "3.1.2" % Test,
     libraryDependencies ++= Seq(
@@ -251,23 +253,19 @@ lazy val scala_libraries_2 = (project in file("scala-libraries-2"))
       "com.beachape" %% "enumeratum" % "1.7.0"
     ),
     libraryDependencies ++= Seq(
-      "com.typesafe.play" %% "play-slick" % "5.0.0",
+      "com.typesafe.play" %% "play-slick" % "5.1.0",
       "org.postgresql" % "postgresql" % "42.2.12"
     ),
     libraryDependencies ++= Seq(
       "io.monix" %% "monix" % monixVersion
     ),
-    libraryDependencies ++= Seq(
-      "org.apache.spark" %% "spark-core" % sparkVersion,
-      "org.apache.spark" %% "spark-sql" % sparkVersion
-    ),
     dependencyOverrides := Seq(
-      "com.typesafe.akka" %% "akka-protobuf-v3" % "2.6.16",
-      "com.typesafe.akka" %% "akka-stream" % "2.6.16",
-      "com.typesafe.akka" %% "akka-serialization-jackson" % "2.6.16"
+      "com.typesafe.akka" %% "akka-protobuf-v3" % "2.6.19",
+      "com.typesafe.akka" %% "akka-stream" % "2.6.19",
+      "com.typesafe.akka" %% "akka-serialization-jackson" % "2.6.19"
     ),
     libraryDependencies ++= Seq(
-      "com.typesafe.akka" %% "akka-actor-testkit-typed" % "2.6.16" % Test,
+      "com.typesafe.akka" %% "akka-actor-testkit-typed" % "2.6.19" % Test,
       "org.scalatest" %% "scalatest" % "3.1.4" % Test,
       "org.scalacheck" %% "scalacheck" % "1.14.1" % Test,
       "com.lihaoyi" %% "requests" % "0.6.9"
@@ -286,8 +284,8 @@ lazy val scala_libraries_3 = (project in file("scala-libraries-3"))
     name := "scala-libraries",
     libraryDependencies += "org.scalatest" %% "scalatest" % "3.1.2" % Test,
     libraryDependencies ++= Seq(
-      "org.apache.spark" %% "spark-core" % sparkVersion,
-      "org.apache.spark" %% "spark-sql" % sparkVersion
+      sparkSqlDep,
+      sparkCoreDep
     ),
     libraryDependencies ++= Seq(
       "org.http4s" %% "http4s-dsl" % http4sVersion,
@@ -328,11 +326,9 @@ lazy val scala_libraries_4 = (project in file("scala-libraries-4"))
     libraryDependencies ++= Seq(
       "org.scala-lang.modules" %% "scala-async" % "1.0.1",
       "org.scala-lang" % "scala-reflect" % scalaVersion.value % Provided,
-      "org.tpolecat" %% "skunk-core" % "0.3.2"
-    ),
-     libraryDependencies ++= Seq(
-      "org.apache.spark" %% "spark-core" % sparkVersion,
-      "org.apache.spark" %% "spark-sql" % sparkVersion
+      "org.tpolecat" %% "skunk-core" % "0.3.2",
+      sparkSqlDep,
+      sparkCoreDep
     ),
     scalacOptions += "-Xasync"
   )
@@ -414,4 +410,4 @@ lazy val scala212 = (project in file("scala212"))
     libraryDependencies ++= Seq(
       scalaTest
     )
-  )
+  )

cats-effects/src/main/scala/com/baeldung/scala/resources/ResourceHandling.scala

@@ -1,12 +1,9 @@
 package com.baeldung.scala.resources
 
-import cats.effect.IO
-import java.io.File
-import scala.io.Source
-import cats.effect.IOApp
-import scala.io.BufferedSource
+import cats.effect.{IO, IOApp, Resource}
+
 import java.io.FileWriter
-import cats.effect.Resource
+import scala.io.Source
 
 object ResourceHandling extends IOApp.Simple {
 

play-scala/async-tasks/build.sbt

@@ -5,6 +5,6 @@ version := "1.0-SNAPSHOT"
 
 lazy val root = (project in file(".")).enablePlugins(PlayScala)
 
-scalaVersion := "2.13.2"
+scalaVersion := "2.13.10"
 
 libraryDependencies += guice

play-scala/caching-in-play/build.sbt

@@ -5,7 +5,7 @@ version := "1.0-SNAPSHOT"
 
 lazy val root = (project in file(".")).enablePlugins(PlayScala)
 
-scalaVersion := "2.13.3"
+scalaVersion := "2.13.10"
 
 libraryDependencies += guice
 libraryDependencies += caffeine

play-scala/configuration-access/build.sbt

@@ -5,7 +5,7 @@ version := "1.0-SNAPSHOT"
 
 lazy val root = (project in file(".")).enablePlugins(PlayScala)
 
-scalaVersion := "2.13.3"
+scalaVersion := "2.13.10"
 
 libraryDependencies += guice
 libraryDependencies += "org.scalatestplus.play" %% "scalatestplus-play" % "5.0.0" % Test

play-scala/custom-error-handling/build.sbt

@@ -5,7 +5,7 @@ version := "1.0-SNAPSHOT"
 
 lazy val root = (project in file(".")).enablePlugins(PlayScala)
 
-scalaVersion := "2.13.2"
+scalaVersion := "2.13.10"
 
 libraryDependencies += guice
 libraryDependencies += "org.scalatestplus.play" %% "scalatestplus-play" % "5.0.0" % Test

play-scala/dependency-injection/build.sbt

@@ -4,7 +4,7 @@ version := "1.0-SNAPSHOT"
 
 lazy val root = (project in file(".")).enablePlugins(PlayScala)
 
-scalaVersion := "2.13.6"
+scalaVersion := "2.13.10"
 
 libraryDependencies += guice
 libraryDependencies += "org.scalatestplus.play" %% "scalatestplus-play" % "5.0.0" % Test

play-scala/introduction-to-play/build.sbt

@@ -4,6 +4,6 @@ version := "1.0-SNAPSHOT"
 
 lazy val root = (project in file(".")).enablePlugins(PlayScala)
 
-scalaVersion := "2.13.2"
+scalaVersion := "2.13.10"
 
 libraryDependencies += guice libraryDependencies += "org.scalatestplus.play" %% "scalatestplus-play" % "5.0.0" % Test

play-scala/play-templates/build.sbt

@@ -5,7 +5,7 @@ version := "1.0-SNAPSHOT"
 
 lazy val root = (project in file(".")).enablePlugins(PlayScala)
 
-scalaVersion := "2.13.2"
+scalaVersion := "2.13.10"
 
 libraryDependencies += guice
 libraryDependencies += "org.scalatestplus.play" %% "scalatestplus-play" % "5.0.0" % Test

play-scala/rest-api/build.sbt

@@ -5,7 +5,7 @@ version := "1.0-SNAPSHOT"
 
 lazy val root = (project in file(".")).enablePlugins(PlayScala)
 
-scalaVersion := "2.13.2"
+scalaVersion := "2.13.10"
 
 libraryDependencies += guice
 libraryDependencies += "org.scalatestplus.play" %% "scalatestplus-play" % "5.0.0" % Test

scala-akka-2/src/main/scala/com/baeldung/scala/akka/http/MovieService.scala

@@ -1,7 +1,6 @@
 package com.baeldung.scala.akka.http
-import scala.concurrent.Future
-import scala.collection.mutable.ListBuffer
 import scala.concurrent.ExecutionContext.Implicits.global
+import scala.concurrent.Future
 
 case class Movie(id: Int, name: String, length: Int)
 

scala-akka/src/main/scala/com/baeldung/scala/akka/alpakka/AlpakkaMongoIntegration.scala

@@ -1,7 +1,5 @@
 package com.baeldung.scala.akka.alpakka
 
-import java.nio.file.FileSystems
-
 import akka.NotUsed
 import akka.stream.alpakka.mongodb.scaladsl.MongoSink
 import akka.stream.scaladsl.Source

scala-akka/src/main/scala/com/baeldung/scala/akka/scheduler/Greetings.scala

@@ -8,6 +8,6 @@ final case class Greeted(msg: String)
 class Greetings extends Actor {
   override def receive: Receive = {
     case greet: Greet =>
-      sender ! Greeted(s"${greet.by}: Hello, ${greet.to}")
+      sender() ! Greeted(s"${greet.by}: Hello, ${greet.to}")
   }
 }

scala-akka/src/main/scala/com/baeldung/scala/akka/stopping/MessageProcessorActor.scala

@@ -1,10 +1,6 @@
 package com.baeldung.scala.akka.stopping
 
 import akka.actor.Actor
-import akka.actor.ActorSystem
-import akka.actor.Props
-import akka.actor.PoisonPill
-import akka.actor.DeadLetter
 
 object MessageProcessorActor {
   trait Message
@@ -19,7 +15,7 @@ class MessageProcessorActor extends Actor {
 
   override def receive: Receive = {
     case msg: MessageProcessorActor.Greet =>
-      sender ! MessageProcessorActor.Reply("Hey, " + msg.msg)
+      sender() ! MessageProcessorActor.Reply("Hey, " + msg.msg)
   }
 
 }

scala-akka/src/main/scala/com/baeldung/scala/akka/supervision/SupervisionApplication.scala

@@ -10,7 +10,7 @@ import com.baeldung.scala.akka.supervision.SupervisionApplication.Filesystem.{Fs
 import com.baeldung.scala.akka.supervision.SupervisionApplication.WebServer.Request
 
 import scala.concurrent.duration.DurationInt
-import scala.util.{Failure, Random, Success, Try}
+import scala.util.{Failure, Success, Try}
 
 object SupervisionApplication {
 

scala-core-2/src/main/scala/com/baeldung/scala/concurrency/FutureAndPromise.scala

@@ -53,7 +53,7 @@ object ScalaAndPromise {
     } yield User(name, email, hashedPassword, avatar)
 
   def runByPromise[T](block: => T)(implicit ec: ExecutionContext): Future[T] = {
-    val p = Promise[T]
+    val p = Promise[T]()
     ec.execute { () =>
       try {
         p.success(block)

scala-core-2/src/main/scala/com/baeldung/scala/exceptionhandling/ExceptionHandling.scala

@@ -21,7 +21,7 @@ object ExceptionHandling {
     try {
       divide(a, 0)
     } catch {
-      case e: DivideByZero => null
+      case _: DivideByZero => null
     } finally {
       println("Finished")
     }

scala-core-3/src/main/scala/com/baeldung/scala/await/AwaitFuture.scala

@@ -1,16 +1,16 @@
 package com.baeldung.scala.await
 
-import scala.concurrent.{ Await, Future }
-import scala.io.Source
 import scala.concurrent.ExecutionContext.Implicits.global
+import scala.concurrent.Future
+import scala.io.Source
 
 object AwaitFuture  {
 
   def fetchDataFromUrl(url : String) : Future[String] = Future {
     Source.fromURL(url).getLines().mkString
   }
 
-  def fetchDataFrom(url : String, waitTime : Long = 0l) : Future[String] =  Future {
+  def fetchDataFrom(url : String, waitTime : Long = 0L) : Future[String] =  Future {
     Thread.sleep(waitTime)
     Source.fromURL(url).getLines().mkString
   }

scala-core-3/src/main/scala/com/baeldung/scala/typecasts/ErrorHandling.scala

@@ -33,7 +33,7 @@ object ErrorHandling extends App {
     case Failure(e: UnknownHostException) =>
       println(s"Unknown host specified: ${e.getMessage}")
     case Failure(e: IOException) =>
-      println("Network failure: ${e.getMessage}")
+      println(s"Network failure: ${e.getMessage}")
     case Failure(t) =>
       t.printStackTrace()
   }

scala-core-4/src/main/scala/com/baeldung/scala/assertvsrequire/RequireUsage.scala

@@ -12,7 +12,7 @@ object RequireUsage extends App {
     issueDrivingLicense("Jr. Darwin", 5) // prints "Failed in require precondition"
   } catch {
     case e: IllegalArgumentException =>
-      println("Failed in require precondition")
+      println("Failed in require precondition-"+e.getMessage)
   }
 
 }

scala-core-5/src/main/scala/com/baeldung/scala/datesandtimes/JavaUtilDate.scala

@@ -3,7 +3,6 @@ import java.text.SimpleDateFormat
 
 import scala.concurrent.duration.Duration
 import scala.concurrent.{Await, Future}
-import scala.languageFeature.experimental.macros
 
 object JavaUtilDate extends App{
 
@@ -29,5 +28,5 @@ object JavaUtilDate extends App{
   val date1 = Await.result(r1, Duration.Inf)
   val date2 = Await.result(r2, Duration.Inf)
 
-  println(date1, date2) // Prints "Wed Jul 01 2020, Fri Aug 21 2020"
+  println(date1 +", "+ date2) // Prints "Wed Jul 01 2020, Fri Aug 21 2020"
 }

scala-core/src/main/scala/com/baeldung/scala/exceptionhandling/Examples.scala

@@ -1,6 +1,6 @@
 package com.baeldung.scala.exceptionhandling
 
-import scala.util.{Failure, Success, Try, control}
+import scala.util.Try
 import scala.util.control.Exception._
 
 object Examples {

scala-design-patterns/src/main/scala/com/baeldung/scala/cakepattern/CakePattern.scala

@@ -1,6 +1,6 @@
 package com.baeldung.scala.cakepattern
 
-import scala.collection.JavaConverters._
+import scala.jdk.CollectionConverters._
 
 object CakePattern {
 

scala-js/build.sbt

@@ -9,7 +9,7 @@ lazy val root = (project in file("."))
     jsEnv := new org.scalajs.jsenv.jsdomnodejs.JSDOMNodeJSEnv()
   )
 
-scalaVersion := "2.13.1"
+scalaVersion := "2.13.10"
 
 scalaJSUseMainModuleInitializer := true
 libraryDependencies += "org.scala-js" %%% "scalajs-dom" % "2.2.0"

scala-lagom/build.sbt

@@ -2,7 +2,7 @@ organization in ThisBuild := "com.baeldung"
 version in ThisBuild := "1.0-SNAPSHOT"
 
 // the Scala version that will be used for cross-compiled libraries
-scalaVersion in ThisBuild := "2.13.0"
+scalaVersion in ThisBuild := "2.13.10"
 
 val macwire = "com.softwaremill.macwire" %% "macros" % "2.3.3" % "provided"
 val scalaTest = "org.scalatest" %% "scalatest" % "3.1.1" % Test

scala-lang-2/src/main/scala/com/baeldung/scala/voidtypes/UnitReturnType.scala

@@ -10,7 +10,7 @@ object UnitReturnType extends App{
   println("result of function returning Unit: %s".format(functionReturnUnit))
 
   def functionReturnImplicitUnit{
-    """
+    s"""
       do something, don't return anything
     """
   }

scala-libraries-2/src/main/scala/com/baeldung/cache/service/AsyncQueryMemoizeService.scala

@@ -4,7 +4,6 @@ import scalacache._
 import scalacache.guava._
 import com.google.common.cache.CacheBuilder
 import scalacache.modes.scalaFuture._
-import scalacache.serialization.binary._
 import scalacache.memoization._
 import scala.concurrent.ExecutionContext.Implicits.global
 

scala-libraries-2/src/main/scala/com/baeldung/cache/service/CatsService.scala

@@ -5,7 +5,6 @@ import com.google.common.cache.CacheBuilder
 import scalacache._
 import scalacache.memoization._
 import scalacache.guava.GuavaCache
-import scala.concurrent.duration._
 
 object GuavaCacheCatsConfig {
   val underlyingGuavaCacheCats =

scala-libraries-2/src/main/scala/com/baeldung/cache/service/SyncQueryCustomMemoizeKeyService.scala

@@ -1,12 +1,10 @@
 package com.baeldung.cache.service
 
+import com.google.common.cache.CacheBuilder
 import scalacache._
 import scalacache.guava._
-import com.google.common.cache.CacheBuilder
-import scalacache.memoization.MethodCallToStringConverter.onlyMethodParams
-import scalacache.modes.sync._
-import scalacache.serialization.binary._
 import scalacache.memoization._
+import scalacache.modes.sync._
 
 import scala.concurrent.duration._