Skip to content

fix: windows tests getting stuck and timing out #930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 11, 2025

Conversation

hrideshmg
Copy link
Contributor

Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

My familiarity with the project is as follows (check one):

  • I have never used the project.
  • I have used the project briefly.
  • I have used the project extensively, but have not contributed previously.
  • I am an active contributor to the project.

The windows tests have been getting stuck and timing out recently. The root cause was with how Rclone handled chunked reads for large files, this PR fixes this issue by passing an option to the underlying FUSE emulator that Rclone uses to modify how chunked reads are handled. For more information on this, refer here.

The timeout has also been reduced to 10 minutes, the reasoning for this is that on previous successful windows tests (such as this one) no single test entry has taken more than two minutes to run.
An entry taking more than 10 more than likely suggests that something has gone wrong. This is more of a preventative measure as Linux tests have also failed as a whole in the past due to single entries taking more than 50 minutes (the current duration).

Copy link

@canihavesomecoffee canihavesomecoffee merged commit e162a7e into CCExtractor:master Jun 11, 2025
2 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants