Skip to content

Commit 84317c0

Browse files
committed
ext/snmp: use memcpy() instead of memmove() (php#10498)
memcpy() may be faster because it does not have to consider overlapping buffers.
1 parent b57bc8d commit 84317c0

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

ext/snmp/snmp.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -399,7 +399,7 @@ static void php_snmp_internal(INTERNAL_FUNCTION_PARAMETERS, int st,
399399
php_snmp_error(getThis(), PHP_SNMP_ERRNO_NOERROR, "");
400400

401401
if (st & SNMP_CMD_WALK) { /* remember root OID */
402-
memmove((char *)root, (char *)(objid_query->vars[0].name), (objid_query->vars[0].name_length) * sizeof(oid));
402+
memcpy((char *)root, (char *)(objid_query->vars[0].name), (objid_query->vars[0].name_length) * sizeof(oid));
403403
rootlen = objid_query->vars[0].name_length;
404404
objid_query->offset = objid_query->count;
405405
}
@@ -553,7 +553,7 @@ static void php_snmp_internal(INTERNAL_FUNCTION_PARAMETERS, int st,
553553
php_snmp_error(getThis(), PHP_SNMP_ERRNO_OID_NOT_INCREASING, "Error: OID not increasing: %s", buf2);
554554
keepwalking = false;
555555
} else {
556-
memmove((char *)(objid_query->vars[0].name), (char *)vars->name, vars->name_length * sizeof(oid));
556+
memcpy((char *)(objid_query->vars[0].name), (char *)vars->name, vars->name_length * sizeof(oid));
557557
objid_query->vars[0].name_length = vars->name_length;
558558
keepwalking = true;
559559
}

0 commit comments

Comments
 (0)