@@ -10,25 +10,25 @@ Use a standard (or LLVM) ``map`` with ``typeinfo`` (would need a specialization
10
10
to expose equality and hasher) for the allocators and the creation
11
11
functions could be a function template.
12
12
13
- ### Use a `` lit test `` instead of a `` unit test `` for the `` logical readers `` .
13
+ ### Use a ** lit test** instead of a ** unit test** for the ** logical readers** .
14
14
** [ D125783] ( https://reviews.llvm.org/D125783#inline-1324376 ) **
15
15
16
16
As the `` DebugInfoLogicalView `` library is sufficiently exposed via the
17
17
`` llvm-debuginfo-analyzer `` tool, follow the LLVM general approach and
18
- use `` LIT `` tests to validate the `` logical readers `` .
18
+ use `` lit `` tests to validate the ** logical readers** .
19
19
20
20
Convert the `` unitests `` :
21
21
```
22
22
llvm-project/llvm/unittests/DebugInfo/LogicalView/CodeViewReaderTest.cpp
23
23
llvm-project/llvm/unittests/DebugInfo/LogicalView/DWARFReaderTest.cpp
24
24
```
25
- into `` LIT tests `` :
25
+ into `` lit `` tests :
26
26
```
27
27
llvm-project/llvm/test/DebugInfo/LogicalView/CodeViewReader.test
28
28
llvm-project/llvm/test/DebugInfo/LogicalView/DWARFReader.test
29
29
```
30
30
31
- ### Eliminate calls to `` getInputFileDirectory() `` in the unit tests .
31
+ ### Eliminate calls to `` getInputFileDirectory() `` in the `` unittests `` .
32
32
** [ D125783] ( https://reviews.llvm.org/D125783#inline-1324359 ) **
33
33
34
34
Rewrite the unittests `` ReaderTest `` and `` CodeViewReaderTest `` to eliminate
@@ -47,7 +47,7 @@ Add the ``PRIx64`` specifier to the printing code (``format()``).
47
47
### Remove `` LVScope::Children `` container.
48
48
** [ D137933] ( https://reviews.llvm.org/D137933#inline-1373902 ) **
49
49
50
- Use a `` chaining iterator `` over the other containers rather than keep a
50
+ Use a ** chaining iterator** over the other containers rather than keep a
51
51
separate container `` Children `` that mirrors their contents.
52
52
53
53
### Use `` TableGen `` for command line options.
@@ -62,10 +62,10 @@ Change command line options to use ``tablegen`` as many other LLVM tools.
62
62
The more idiomatic LLVM way to handle this would be to have `` find ``
63
63
return `` Optional<ValueType> `` .
64
64
65
- ### Pass references instead of pointers (`` Comparison functions `` ).
65
+ ### Pass references instead of pointers (** Comparison functions** ).
66
66
** [ D125782] ( https://reviews.llvm.org/D125782#inline-1293920 ) **
67
67
68
- In the `` comparison functions `` , pass references instead of pointers (when
68
+ In the ** comparison functions** , pass references instead of pointers (when
69
69
pointers cannot be null).
70
70
71
71
### Use `` StringMap `` where possible.
@@ -78,26 +78,26 @@ because the key is not a ``std::string``.
78
78
Replace the use of `` std::map<std::string, ValueType> `` with `` StringMap `` .
79
79
One specific case is the `` LVSymbolNames `` definitions.
80
80
81
- ### Calculate unique offset for `` CodeView `` elements.
82
- In order to have the same logical functionality as the `` DWARF `` reader, such
81
+ ### Calculate unique offset for CodeView elements.
82
+ In order to have the same logical functionality as the DWARF reader, such
83
83
as:
84
84
85
85
* find scopes contribution to debug info
86
86
* sort by its physical location
87
87
88
- The logical elements must have an unique offset (similar like the `` DWARF
89
- DIE offset`` ).
88
+ The logical elements must have an unique offset (similar like the DWARF
89
+ `` DIE `` offset ).
90
90
91
- ### Move `` initializeFileAndStringTables `` to the `` CodeView `` Library.
92
- There is some code in the `` CodeView `` reader that was extracted/adapted
93
- from `` tools/llvm-readobj/COFFDumper.cpp `` that can be moved to the `` CodeView ``
91
+ ### Move `` initializeFileAndStringTables `` to the CodeView Library.
92
+ There is some code in the CodeView reader that was extracted/adapted
93
+ from `` tools/llvm-readobj/COFFDumper.cpp `` that can be moved to the CodeView
94
94
library.
95
95
96
96
We had a similar case with code shared with `` llvm-pdbutil `` that was moved
97
- to the `` PDB `` library: ** [ D122226] ( https://reviews.llvm.org/D122226 ) **
97
+ to the PDB library: ** [ D122226] ( https://reviews.llvm.org/D122226 ) **
98
98
99
- ### Move `` getSymbolKindName `` and `` formatRegisterId `` to the `` CodeView `` Library.
100
- There is some code in the `` CodeView `` reader that was extracted/adapted
99
+ ### Move `` getSymbolKindName `` and `` formatRegisterId `` to the CodeView Library.
100
+ There is some code in the CodeView reader that was extracted/adapted
101
101
from `` lib/DebugInfo/CodeView/SymbolDumper.cpp `` that can be used.
102
102
103
103
### Use of `` std::unordered_set `` instead of `` std::set `` .
@@ -129,9 +129,9 @@ common module.
129
129
[ D137156] ( https://reviews.llvm.org/D137156 ) **
130
130
131
131
During the traversal of the debug information sections, we created the
132
- logical lines representing the `` disassembled instructions `` from the `` text
133
- section`` and the logical lines representing the `` line records`` from the
134
- `` debug line `` section. Using the ranges associated with the logical scopes,
132
+ logical lines representing the ** disassembled instructions** from the ** text
133
+ section** and the logical lines representing the ** line records** from the
134
+ ** debug line** section. Using the ranges associated with the logical scopes,
135
135
we will allocate those logical lines to their logical scopes.
136
136
137
137
Consider the case when any of those lines become orphans, causing
@@ -143,27 +143,27 @@ incorrect scope parent for disassembly or line records.
143
143
Only linked executables are handled. It does not support relocatable
144
144
files compiled with `` -ffunction-sections `` .
145
145
146
- ### Add support for DWARF v5 .debug_names section / CodeView public symbols stream.
146
+ ### Add support for DWARF v5 ` .debug_names ` section / CodeView public symbols stream.
147
147
** [ D125783] ( https://reviews.llvm.org/D125783#inline-1294142 ) **
148
148
149
- The `` DWARF `` and `` CodeView `` readers use the public names information to create
150
- the instructions (`` LVLineAssembler `` ). Instead of relying on `` DWARF `` section
151
- names (`` .debug_pubnames `` , `` .debug_names `` ) and `` CodeView `` `` public symbol `` stream
149
+ The DWARF and CodeView readers use the public names information to create
150
+ the instructions (`` LVLineAssembler `` ). Instead of relying on DWARF section
151
+ names (`` .debug_pubnames `` , `` .debug_names `` ) and CodeView public symbol stream
152
152
(`` S_PUB32 `` ), the readers should collect the needed information while processing
153
153
the debug information.
154
154
155
155
If the object file supports the above section names and stream, use them
156
156
to create the public names.
157
157
158
- ### Add support for some extra ` DWARF ` locations.
159
- The following `` DWARF `` debug location operands are not supported:
158
+ ### Add support for some extra DWARF locations.
159
+ The following DWARF debug location operands are not supported:
160
160
161
- * DW_OP_const_type
162
- * DW_OP_entry_value
163
- * DW_OP_implicit_value
161
+ * ` DW_OP_const_type `
162
+ * ` DW_OP_entry_value `
163
+ * ` DW_OP_implicit_value `
164
164
165
165
### Add support for additional binary formats.
166
- * Extended COFF `` ( XCOFF) ``
166
+ * Extended COFF ( ` XCOFF ` )
167
167
168
168
### Add support for `` JSON `` or `` YAML ``
169
169
The logical view uses its own and non-standard free form text when
0 commit comments