Skip to content

Commit c9cccc5

Browse files
[llvm-debuginfo-analyzer][DOC] Convert 'README.txt' to markdown.
As part of the WebAssembly support work llvm#85566 The README.txt is a bit odd since it only lists issues and problems without talking about what works. It’s also hard to read on the GitHub web view. - Address more feedback in relation to the correct Use of monospace. - Keep DWARF, CodeView, PDB as plain text.
1 parent d6a6da9 commit c9cccc5

File tree

1 file changed

+30
-30
lines changed

1 file changed

+30
-30
lines changed

llvm/tools/llvm-debuginfo-analyzer/README.md

Lines changed: 30 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -10,25 +10,25 @@ Use a standard (or LLVM) ``map`` with ``typeinfo`` (would need a specialization
1010
to expose equality and hasher) for the allocators and the creation
1111
functions could be a function template.
1212

13-
### Use a ``lit test`` instead of a ``unit test`` for the ``logical readers``.
13+
### Use a **lit test** instead of a **unit test** for the **logical readers**.
1414
**[D125783](https://reviews.llvm.org/D125783#inline-1324376)**
1515

1616
As the ``DebugInfoLogicalView`` library is sufficiently exposed via the
1717
``llvm-debuginfo-analyzer`` tool, follow the LLVM general approach and
18-
use ``LIT`` tests to validate the ``logical readers``.
18+
use ``lit`` tests to validate the **logical readers**.
1919

2020
Convert the ``unitests``:
2121
```
2222
llvm-project/llvm/unittests/DebugInfo/LogicalView/CodeViewReaderTest.cpp
2323
llvm-project/llvm/unittests/DebugInfo/LogicalView/DWARFReaderTest.cpp
2424
```
25-
into ``LIT tests``:
25+
into ``lit`` tests:
2626
```
2727
llvm-project/llvm/test/DebugInfo/LogicalView/CodeViewReader.test
2828
llvm-project/llvm/test/DebugInfo/LogicalView/DWARFReader.test
2929
```
3030

31-
### Eliminate calls to ``getInputFileDirectory()`` in the unit tests.
31+
### Eliminate calls to ``getInputFileDirectory()`` in the ``unittests``.
3232
**[D125783](https://reviews.llvm.org/D125783#inline-1324359)**
3333

3434
Rewrite the unittests ``ReaderTest`` and ``CodeViewReaderTest`` to eliminate
@@ -47,7 +47,7 @@ Add the ``PRIx64`` specifier to the printing code (``format()``).
4747
### Remove ``LVScope::Children`` container.
4848
**[D137933](https://reviews.llvm.org/D137933#inline-1373902)**
4949

50-
Use a ``chaining iterator`` over the other containers rather than keep a
50+
Use a **chaining iterator** over the other containers rather than keep a
5151
separate container ``Children`` that mirrors their contents.
5252

5353
### Use ``TableGen`` for command line options.
@@ -62,10 +62,10 @@ Change command line options to use ``tablegen`` as many other LLVM tools.
6262
The more idiomatic LLVM way to handle this would be to have ``find``
6363
return ``Optional<ValueType>``.
6464

65-
### Pass references instead of pointers (``Comparison functions``).
65+
### Pass references instead of pointers (**Comparison functions**).
6666
**[D125782](https://reviews.llvm.org/D125782#inline-1293920)**
6767

68-
In the ``comparison functions``, pass references instead of pointers (when
68+
In the **comparison functions**, pass references instead of pointers (when
6969
pointers cannot be null).
7070

7171
### Use ``StringMap`` where possible.
@@ -78,26 +78,26 @@ because the key is not a ``std::string``.
7878
Replace the use of ``std::map<std::string, ValueType>`` with ``StringMap``.
7979
One specific case is the ``LVSymbolNames`` definitions.
8080

81-
### Calculate unique offset for ``CodeView`` elements.
82-
In order to have the same logical functionality as the ``DWARF`` reader, such
81+
### Calculate unique offset for CodeView elements.
82+
In order to have the same logical functionality as the DWARF reader, such
8383
as:
8484

8585
* find scopes contribution to debug info
8686
* sort by its physical location
8787

88-
The logical elements must have an unique offset (similar like the ``DWARF
89-
DIE offset``).
88+
The logical elements must have an unique offset (similar like the DWARF
89+
``DIE`` offset).
9090

91-
### Move ``initializeFileAndStringTables`` to the ``CodeView`` Library.
92-
There is some code in the ``CodeView`` reader that was extracted/adapted
93-
from ``tools/llvm-readobj/COFFDumper.cpp`` that can be moved to the ``CodeView``
91+
### Move ``initializeFileAndStringTables`` to the CodeView Library.
92+
There is some code in the CodeView reader that was extracted/adapted
93+
from ``tools/llvm-readobj/COFFDumper.cpp`` that can be moved to the CodeView
9494
library.
9595

9696
We had a similar case with code shared with ``llvm-pdbutil`` that was moved
97-
to the ``PDB`` library: **[D122226](https://reviews.llvm.org/D122226)**
97+
to the PDB library: **[D122226](https://reviews.llvm.org/D122226)**
9898

99-
### Move ``getSymbolKindName`` and ``formatRegisterId`` to the ``CodeView`` Library.
100-
There is some code in the ``CodeView`` reader that was extracted/adapted
99+
### Move ``getSymbolKindName`` and ``formatRegisterId`` to the CodeView Library.
100+
There is some code in the CodeView reader that was extracted/adapted
101101
from ``lib/DebugInfo/CodeView/SymbolDumper.cpp`` that can be used.
102102

103103
### Use of ``std::unordered_set`` instead of ``std::set``.
@@ -129,9 +129,9 @@ common module.
129129
[D137156](https://reviews.llvm.org/D137156)**
130130

131131
During the traversal of the debug information sections, we created the
132-
logical lines representing the ``disassembled instructions`` from the ``text
133-
section`` and the logical lines representing the ``line records`` from the
134-
``debug line`` section. Using the ranges associated with the logical scopes,
132+
logical lines representing the **disassembled instructions** from the **text
133+
section** and the logical lines representing the **line records** from the
134+
**debug line** section. Using the ranges associated with the logical scopes,
135135
we will allocate those logical lines to their logical scopes.
136136

137137
Consider the case when any of those lines become orphans, causing
@@ -143,27 +143,27 @@ incorrect scope parent for disassembly or line records.
143143
Only linked executables are handled. It does not support relocatable
144144
files compiled with ``-ffunction-sections``.
145145

146-
### Add support for DWARF v5 .debug_names section / CodeView public symbols stream.
146+
### Add support for DWARF v5 `.debug_names` section / CodeView public symbols stream.
147147
**[D125783](https://reviews.llvm.org/D125783#inline-1294142)**
148148

149-
The ``DWARF`` and ``CodeView`` readers use the public names information to create
150-
the instructions (``LVLineAssembler``). Instead of relying on ``DWARF`` section
151-
names (``.debug_pubnames``, ``.debug_names``) and ``CodeView`` ``public symbol`` stream
149+
The DWARF and CodeView readers use the public names information to create
150+
the instructions (``LVLineAssembler``). Instead of relying on DWARF section
151+
names (``.debug_pubnames``, ``.debug_names``) and CodeView public symbol stream
152152
(``S_PUB32``), the readers should collect the needed information while processing
153153
the debug information.
154154

155155
If the object file supports the above section names and stream, use them
156156
to create the public names.
157157

158-
### Add support for some extra `DWARF` locations.
159-
The following ``DWARF`` debug location operands are not supported:
158+
### Add support for some extra DWARF locations.
159+
The following DWARF debug location operands are not supported:
160160

161-
* DW_OP_const_type
162-
* DW_OP_entry_value
163-
* DW_OP_implicit_value
161+
* `DW_OP_const_type`
162+
* `DW_OP_entry_value`
163+
* `DW_OP_implicit_value`
164164

165165
### Add support for additional binary formats.
166-
* Extended COFF ``(XCOFF)``
166+
* Extended COFF (`XCOFF`)
167167

168168
### Add support for ``JSON`` or ``YAML``
169169
The logical view uses its own and non-standard free form text when

0 commit comments

Comments
 (0)