Skip to content

Commit d00f7db

Browse files
Fixed some html codacy has beef with
1 parent 0ac5aee commit d00f7db

File tree

3 files changed

+16
-11
lines changed

3 files changed

+16
-11
lines changed

README.md

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,21 +20,26 @@ The downloaded tile cache gets large very quickly -128kB per tile- so a ESP32 wi
2020
### Functions
2121

2222
#### Set map resolution
23+
2324
```c++
2425
void setResolution(uint16_t w, uint16_t h);
2526
```
2627
2728
#### Resize cache
29+
2830
```c++
2931
bool resizeTilesCache(uint8_t numberOfTiles);
3032
```
3133
**Note**: Each tile is 128 kB.
3234

3335
#### Free the memory used by the tile cache
36+
3437
```c++
3538
void freeTilesCache();
3639
```
37-
#### Fetch a map
40+
41+
#### Fetch a map
42+
3843
```c++
3944
bool fetchMap(LGFX_Sprite &map, double longitude, double latitude, uint8_t zoom);
4045
```

src/OpenStreetMap-esp32.cpp

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -412,11 +412,11 @@ bool OpenStreetMap::downloadAndDecodeTile(CachedTile &tile, uint32_t x, uint32_t
412412
return true;
413413
}
414414

415-
bool OpenStreetMap::saveMap(const char *filename, LGFX_Sprite &sprite, String &result, uint8_t sdPin)
415+
bool OpenStreetMap::saveMap(const char *filename, LGFX_Sprite &map, String &result, uint8_t sdPin)
416416
{
417417
log_i("Saving map, this may take a while...");
418418

419-
if (!sprite.getBuffer())
419+
if (!map.getBuffer())
420420
{
421421
result = "No data in map!";
422422
return false;
@@ -438,17 +438,17 @@ bool OpenStreetMap::saveMap(const char *filename, LGFX_Sprite &sprite, String &r
438438

439439
// BMP header (54 bytes)
440440
uint16_t bfType = 0x4D42; // "BM"
441-
uint32_t bfSize = 54 + sprite.width() * sprite.height() * 3; // Header + pixel data (3 bytes per pixel for RGB888)
441+
uint32_t bfSize = 54 + map.width() * map.height() * 3; // Header + pixel data (3 bytes per pixel for RGB888)
442442
uint16_t bfReserved = 0;
443443
uint32_t bfOffBits = 54; // Offset to pixel data
444444

445445
uint32_t biSize = 40; // Info header size
446-
int32_t biWidth = sprite.width();
447-
int32_t biHeight = -sprite.height(); // Negative to flip vertically
446+
int32_t biWidth = map.width();
447+
int32_t biHeight = -map.height(); // Negative to flip vertically
448448
uint16_t biPlanes = 1;
449449
uint16_t biBitCount = 24; // RGB888 format
450450
uint32_t biCompression = 0;
451-
uint32_t biSizeImage = sprite.width() * sprite.height() * 3; // 3 bytes per pixel
451+
uint32_t biSizeImage = map.width() * map.height() * 3; // 3 bytes per pixel
452452
int32_t biXPelsPerMeter = 0;
453453
int32_t biYPelsPerMeter = 0;
454454
uint32_t biClrUsed = 0;
@@ -472,11 +472,11 @@ bool OpenStreetMap::saveMap(const char *filename, LGFX_Sprite &sprite, String &r
472472
file.write(reinterpret_cast<const uint8_t *>(&biClrUsed), sizeof(biClrUsed));
473473
file.write(reinterpret_cast<const uint8_t *>(&biClrImportant), sizeof(biClrImportant));
474474

475-
for (int y = 0; y < sprite.height(); y++)
475+
for (int y = 0; y < map.height(); y++)
476476
{
477-
for (int x = 0; x < sprite.width(); x++)
477+
for (int x = 0; x < map.width(); x++)
478478
{
479-
uint16_t rgb565Color = sprite.readPixel(x, y); // Read pixel color (RGB565 format)
479+
uint16_t rgb565Color = map.readPixel(x, y); // Read pixel color (RGB565 format)
480480
uint8_t red5 = (rgb565Color >> 11) & 0x1F;
481481
uint8_t green6 = (rgb565Color >> 5) & 0x3F;
482482
uint8_t blue5 = rgb565Color & 0x1F;

src/OpenStreetMap-esp32.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ class OpenStreetMap
5656
bool resizeTilesCache(uint8_t numberOfTiles);
5757
void freeTilesCache();
5858
bool fetchMap(LGFX_Sprite &sprite, double longitude, double latitude, uint8_t zoom);
59-
bool saveMap(const char *filename, LGFX_Sprite &display, String &result, uint8_t sdPin = SS);
59+
bool saveMap(const char *filename, LGFX_Sprite &map, String &result, uint8_t sdPin = SS);
6060

6161
private:
6262
static OpenStreetMap *currentInstance;

0 commit comments

Comments
 (0)