Skip to content

Commit 6a28718

Browse files
committed
Merge branch '2.3'
* 2.3: Run all tests in parallel. Fixed an entity class name. [HttpKernel] fix usage of deprecated FlattenException Conflicts: src/Symfony/Component/HttpKernel/EventListener/ExceptionListener.php
2 parents 3ab5457 + 453f0d2 commit 6a28718

File tree

8 files changed

+23
-14
lines changed

8 files changed

+23
-14
lines changed

.travis.yml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,13 @@ php:
77
- 5.5
88

99
before_script:
10+
- sudo apt-get install parallel
1011
- echo '' > ~/.phpenv/versions/$(phpenv version-name)/etc/conf.d/xdebug.ini
1112
- sh -c 'if [ $(php -r "echo PHP_MINOR_VERSION;") -le 4 ]; then echo "extension = apc.so" >> ~/.phpenv/versions/$(phpenv version-name)/etc/php.ini; fi;'
1213
- COMPOSER_ROOT_VERSION=dev-master composer --prefer-source --dev install
14+
- php src/Symfony/Component/Locale/Resources/data/build-data.php
15+
- export USE_INTL_ICU_DATA_VERSION=1
16+
17+
script:
18+
- ls -d src/Symfony/*/* | parallel --gnu --keep-order 'echo "Running {} tests"; phpunit --exclude-group tty,benchmark {};' || exit 1
19+
- echo "Running tests requiring tty"; phpunit --group tty

src/Symfony/Bridge/Doctrine/Tests/Form/Type/EntityTypePerformanceTest.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@
1111

1212
namespace Symfony\Bridge\Doctrine\Tests\Form\Type;
1313

14-
use Symfony\Component\Form\Test\FormPerformanceTestCase;
15-
use Symfony\Bridge\Doctrine\Tests\Fixtures\SingleIdentEntity;
14+
use Symfony\Component\Form\Tests\FormPerformanceTestCase;
15+
use Symfony\Bridge\Doctrine\Tests\Fixtures\SingleIntIdEntity;
1616
use Doctrine\ORM\Tools\SchemaTool;
1717
use Symfony\Bridge\Doctrine\Tests\DoctrineOrmTestCase;
1818
use Symfony\Component\Form\Extension\Core\CoreExtension;
@@ -23,7 +23,7 @@
2323
*/
2424
class EntityTypePerformanceTest extends FormPerformanceTestCase
2525
{
26-
const ENTITY_CLASS = 'Symfony\Bridge\Doctrine\Tests\Fixtures\SingleIdentEntity';
26+
const ENTITY_CLASS = 'Symfony\Bridge\Doctrine\Tests\Fixtures\SingleIntIdEntity';
2727

2828
/**
2929
* @var \Doctrine\ORM\EntityManager

src/Symfony/Bundle/TwigBundle/Controller/ExceptionController.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
namespace Symfony\Bundle\TwigBundle\Controller;
1313

1414
use Symfony\Bundle\FrameworkBundle\Templating\TemplateReference;
15-
use Symfony\Component\HttpKernel\Exception\FlattenException;
15+
use Symfony\Component\Debug\Exception\FlattenException;
1616
use Symfony\Component\HttpKernel\Log\DebugLoggerInterface;
1717
use Symfony\Component\HttpFoundation\Request;
1818
use Symfony\Component\HttpFoundation\Response;

src/Symfony/Bundle/TwigBundle/Tests/Controller/ExceptionControllerTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ class ExceptionControllerTest extends TestCase
1919
{
2020
public function testOnlyClearOwnOutputBuffers()
2121
{
22-
$flatten = $this->getMock('Symfony\Component\HttpKernel\Exception\FlattenException');
22+
$flatten = $this->getMock('Symfony\Component\Debug\Exception\FlattenException');
2323
$flatten
2424
->expects($this->once())
2525
->method('getStatusCode')

src/Symfony/Component/Console/Tests/Helper/DialogHelperTest.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,9 @@ public function testAskWithAutocomplete()
9595
$this->assertEquals('FooBundle', $dialog->ask($this->getOutputStream(), 'Please select a bundle', 'FrameworkBundle', $bundles));
9696
}
9797

98+
/**
99+
* @group tty
100+
*/
98101
public function testAskHiddenResponse()
99102
{
100103
if (defined('PHP_WINDOWS_VERSION_BUILD')) {

src/Symfony/Component/HttpKernel/DataCollector/ExceptionDataCollector.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,9 @@
1111

1212
namespace Symfony\Component\HttpKernel\DataCollector;
1313

14+
use Symfony\Component\Debug\Exception\FlattenException;
1415
use Symfony\Component\HttpFoundation\Request;
1516
use Symfony\Component\HttpFoundation\Response;
16-
use Symfony\Component\HttpKernel\Exception\FlattenException;
1717

1818
/**
1919
* ExceptionDataCollector.

src/Symfony/Component/HttpKernel/EventListener/ExceptionListener.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,11 @@
1313

1414
use Psr\Log\LoggerInterface;
1515
use Symfony\Component\HttpFoundation\Request;
16+
use Symfony\Component\Debug\Exception\FlattenException;
1617
use Symfony\Component\HttpKernel\Log\DebugLoggerInterface;
1718
use Symfony\Component\HttpKernel\Event\GetResponseForExceptionEvent;
1819
use Symfony\Component\HttpKernel\KernelEvents;
1920
use Symfony\Component\HttpKernel\HttpKernelInterface;
20-
use Symfony\Component\HttpKernel\Exception\FlattenException;
2121
use Symfony\Component\HttpKernel\Exception\HttpExceptionInterface;
2222
use Symfony\Component\EventDispatcher\EventSubscriberInterface;
2323

src/Symfony/Component/HttpKernel/Tests/DataCollector/ExceptionDataCollectorTest.php

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@
1111

1212
namespace Symfony\Component\HttpKernel\Tests\DataCollector;
1313

14+
use Symfony\Component\Debug\Exception\FlattenException;
1415
use Symfony\Component\HttpKernel\DataCollector\ExceptionDataCollector;
15-
use Symfony\Component\HttpKernel\Exception\FlattenException;
1616
use Symfony\Component\HttpFoundation\Request;
1717
use Symfony\Component\HttpFoundation\Response;
1818

@@ -30,11 +30,10 @@ public function testCollect()
3030
$c->collect(new Request(), new Response(),$e);
3131

3232
$this->assertTrue($c->hasException());
33-
$this->assertEquals($flattened,$c->getException());
34-
$this->assertSame('foo',$c->getMessage());
35-
$this->assertSame(500,$c->getCode());
36-
$this->assertSame('exception',$c->getName());
37-
$this->assertSame($trace,$c->getTrace());
33+
$this->assertEquals($flattened, $c->getException());
34+
$this->assertSame('foo', $c->getMessage());
35+
$this->assertSame(500, $c->getCode());
36+
$this->assertSame('exception', $c->getName());
37+
$this->assertSame($trace, $c->getTrace());
3838
}
39-
4039
}

0 commit comments

Comments
 (0)