bug symfony#10095 [Security] fix DI for SimpleFormAuthenticationListener (Tobion)

This PR was merged into the 2.4 branch.

Discussion
----------

[Security] fix DI for SimpleFormAuthenticationListener

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | symfony#10093
| License       | MIT
| Doc PR        | -

The problematic commit was symfony@f2f15f5

Commits
-------

b3f5fa9 [Security] fix DI for SimpleFormAuthenticationListener

Author: fabpot

src/Symfony/Bundle/SecurityBundle/DependencyInjection/Security/Factory/FormLoginFactory.php

@@ -75,12 +75,10 @@ protected function createListener($container, $id, $config, $userProvider)
     {
         $listenerId = parent::createListener($container, $id, $config, $userProvider);
 
-        if (isset($config['csrf_provider'])) {
-            $container
-                ->getDefinition($listenerId)
-                ->addArgument(new Reference($config['csrf_provider']))
-            ;
-        }
+        $container
+            ->getDefinition($listenerId)
+            ->addArgument(isset($config['csrf_provider']) ? new Reference($config['csrf_provider']) : null)
+        ;
 
         return $listenerId;
     }

src/Symfony/Bundle/SecurityBundle/DependencyInjection/Security/Factory/SimpleFormFactory.php

@@ -63,18 +63,14 @@ protected function createAuthProvider(ContainerBuilder $container, $id, $config,
     protected function createListener($container, $id, $config, $userProvider)
     {
         $listenerId = parent::createListener($container, $id, $config, $userProvider);
-        $listener = $container->getDefinition($listenerId);
-
-        if (!isset($config['csrf_token_generator'])) {
-            $listener->addArgument(null);
-        }
 
         $simpleAuthHandlerId = 'security.authentication.simple_success_failure_handler.'.$id;
         $simpleAuthHandler = $container->setDefinition($simpleAuthHandlerId, new DefinitionDecorator('security.authentication.simple_success_failure_handler'));
         $simpleAuthHandler->replaceArgument(0, new Reference($config['authenticator']));
         $simpleAuthHandler->replaceArgument(1, new Reference($this->getSuccessHandlerId($id)));
         $simpleAuthHandler->replaceArgument(2, new Reference($this->getFailureHandlerId($id)));
 
+        $listener = $container->getDefinition($listenerId);
         $listener->replaceArgument(5, new Reference($simpleAuthHandlerId));
         $listener->replaceArgument(6, new Reference($simpleAuthHandlerId));
         $listener->addArgument(new Reference($config['authenticator']));