[Process] Add tests on ProcessUtils::escapeArgument

Author: romainneutron

src/Symfony/Component/Process/ProcessUtils.php

@@ -57,15 +57,15 @@ public static function escapeArgument($argument)
                         $part .= '\\';
                     }
                     $part = escapeshellarg($part);
-                    if ($part[0] === '"' && $part[strlen($part) - 1] === '"') {
+                    if ('"' === $part[0] && '"' === $part[strlen($part) - 1]) {
                         $part = substr($part, 1, -1);
                         $quote = true;
                     }
                     $escapedArgument .= $part;
                 }
             }
             if ($quote) {
-                $escapedArgument = '"' . $escapedArgument . '"';
+                $escapedArgument = '"'.$escapedArgument.'"';
             }
 
             return $escapedArgument;

src/Symfony/Component/Process/Tests/ProcessUtilsTest.php

@@ -27,6 +27,7 @@ public function dataArguments()
     {
         if (defined('PHP_WINDOWS_VERSION_BUILD')) {
             return array(
+                array('"\"php\" \"-v\""', '"php" "-v"'),
                 array('"foo bar"', 'foo bar'),
                 array('^%"path"^%', '%path%'),
                 array('"<|>"\\"" "\\""\'f"', '<|>" "\'f'),
@@ -36,6 +37,7 @@ public function dataArguments()
         }
 
         return array(
+            array("'\"php\" \"-v\"'", '"php" "-v"'),
             array("'foo bar'", 'foo bar'),
             array("'%path%'", '%path%'),
             array("'<|>\" \"'\\''f'", '<|>" "\'f'),