Cleanup unused function and redundant variable assignment

Author: Xon

src/scripts/choices.ts

@@ -1367,8 +1367,6 @@ class Choices {
       return;
     }
 
-    const hasUnactiveChoices = this._store.choices.some((option) => !option.active);
-
     // Check that we have a value to search and the input was an alphanumeric character
     if (value !== null && typeof value !== 'undefined' && value.length >= this.config.searchFloor) {
       const resultCount = this.config.searchChoices ? this._searchChoices(value) : 0;
@@ -1379,7 +1377,7 @@ class Choices {
           resultCount,
         });
       }
-    } else if (hasUnactiveChoices) {
+    } else if (this._store.choices.some((option) => !option.active)) {
       this._stopSearch();
     }
   }

src/scripts/components/list.ts

@@ -13,10 +13,6 @@ export default class List {
     this.height = this.element.offsetHeight;
   }
 
-  clear(): void {
-    this.element.innerHTML = '';
-  }
-
   prepend(node: Element | DocumentFragment): void {
     const child = this.element.firstElementChild;
     if (child) {

test/scripts/components/list.test.ts

@@ -36,62 +36,6 @@ describe('components/list', () => {
     });
   });
 
-  describe('clear', () => {
-    it("clears element's inner HTML", () => {
-      expect(instance).to.not.be.null;
-      if (!instance) {
-        return;
-      }
-      const innerHTML = 'test';
-      instance.element.innerHTML = innerHTML;
-      expect(instance.element.innerHTML).to.equal(innerHTML);
-      instance.clear();
-      expect(instance.element.innerHTML).to.equal('');
-    });
-  });
-
-  describe('append', () => {
-    it('appends passed node to element', () => {
-      expect(instance).to.not.be.null;
-      if (!instance) {
-        return;
-      }
-      const elementToAppend = document.createElement('span');
-      const childClass = 'test-element';
-      elementToAppend.classList.add(...getClassNames(childClass));
-      expect(instance.element.querySelector(`.${childClass}`)).to.equal(null);
-      instance.element.append(elementToAppend);
-      expect(instance.element.querySelector(`.${childClass}`)).to.equal(elementToAppend);
-    });
-  });
-
-  describe('hasChildren', () => {
-    describe('when list has children', () => {
-      it('returns true', () => {
-        expect(instance).to.not.be.null;
-        if (!instance) {
-          return;
-        }
-        const childElement = document.createElement('span');
-        instance.element.appendChild(childElement);
-        const response = instance.element.hasChildNodes();
-        expect(response).to.equal(true);
-      });
-    });
-
-    describe('when list does not have children', () => {
-      it('returns false', () => {
-        expect(instance).to.not.be.null;
-        if (!instance) {
-          return;
-        }
-        instance.element.innerHTML = '';
-        const response = instance.element.hasChildNodes();
-        expect(response).to.equal(false);
-      });
-    });
-  });
-
   describe('scrollToTop', () => {
     it("sets the position's scroll position to 0", () => {
       expect(instance).to.not.be.null;