Fixed ColumnLowCardinality::Clear()
#49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enmk
force-pushed
the
LowCardinality-Clear-fix
branch
from
162c150 to
ef0e515
Compare
traceon
approved these changes
Sep 3, 2020
| @@ -125,18 +127,19 @@ ColumnLowCardinality::ColumnLowCardinality(ColumnRef dictionary_column) | |||
| { | |||
There was a problem hiding this comment.
The prototype of ColumnLowCardinality::ColumnLowCardinality(ColumnRef dictionary_column) should accept ColumnRef && dictionary_column to denote that the original object pointed by the ColumnRef = shared_ptr<> is modified/consumed.
There was a problem hiding this comment.
Designed a better way to copy values from source column, without all those shenanigans, so this is fixed now
Enmk
force-pushed
the
LowCardinality-Clear-fix
branch
from
c3bce56 to
7b3fcdc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now
ColumnLowCardinality-column can be safely reused after being cleared.Added unit-tests and integration tests to validate fix.