Apply fixes from StyleCI (#130)

Co-authored-by: Gregor Becker <[email protected]>

Author: CodeDredd

src/Driver/ExtSoap/AbusedClient.php

@@ -62,7 +62,7 @@ public function __doRequest($request, $location, $action, $version, $oneWay = 0)
 
     public function collectRequest(): SoapRequest
     {
-        if (!$this->storedRequest) {
+        if (! $this->storedRequest) {
             throw new \RuntimeException('No request has been registered yet.');
         }
 
@@ -80,12 +80,12 @@ public function cleanUpTemporaryState()
         $this->storedResponse = null;
     }
 
-    public function __getLastRequest() : string
+    public function __getLastRequest(): string
     {
         return $this->__last_request;
     }
 
-    public function __getLastResponse() : string
+    public function __getLastResponse(): string
     {
         return $this->__last_response;
     }

src/Driver/ExtSoap/ExtSoapDecoder.php

@@ -34,6 +34,7 @@ public function decode(string $method, SoapResponse $response)
         } finally {
             $this->client->cleanUpTemporaryState();
         }
+
         return $decoded;
     }
 }

src/Driver/ExtSoap/ExtSoapDriver.php

@@ -40,7 +40,6 @@ public function __construct(
         DecoderInterface $decoder,
         MetadataInterface $metadata
     ) {
-
         $this->client = $client;
         $this->encoder = $encoder;
         $this->decoder = $decoder;

src/Driver/ExtSoap/Metadata/MethodsParser.php

@@ -36,6 +36,7 @@ function (string $methodString) {
     private function parseMethodFromString(string $methodString): Method
     {
         $methodString = $this->transformListResponseToArray($methodString);
+
         return new Method(
             $this->parseName($methodString),
             $this->parseParameters($methodString),
@@ -54,15 +55,15 @@ private function transformListResponseToArray(string $methodString): string
     private function parseParameters(string $methodString): array
     {
         preg_match('/\((.*)\)/', $methodString, $properties);
-        if (!$properties[1]) {
+        if (! $properties[1]) {
             return [];
         }
 
         $parameters = preg_split('/,\s?/', $properties[1]);
 
         return array_map(
             function (string $parameter): Parameter {
-                list($type, $name) = explode(' ', trim($parameter));
+                [$type, $name] = explode(' ', trim($parameter));
 
                 return new Parameter(
                     ltrim($name, '$'),

src/Driver/ExtSoap/Metadata/TypesParser.php

@@ -30,7 +30,7 @@ public function parse(AbusedClient $abusedClient): TypeCollection
         foreach ($soapTypes as $soapType) {
             $properties = [];
             $lines = explode("\n", $soapType);
-            if (!preg_match('/struct (?P<typeName>.*) {/', $lines[0], $matches)) {
+            if (! preg_match('/struct (?P<typeName>.*) {/', $lines[0], $matches)) {
                 continue;
             }
             $xsdType = XsdType::create($matches['typeName']);

tests/Unit/SoapClientTest.php

@@ -137,20 +137,17 @@ public function testSoapOptions(): void
         self::assertStringContainsString('application/soap+xml; charset="utf-8', $lastRequestInfo->getLastRequestHeaders());
     }
 
-    /**
-     *
-     */
     public function testRealSoapCall(): void
     {
         $this->markTestSkipped('Real Soap Call Testing. Comment the line out for testing');
         // location has to be set because the wsdl has a wrong location declaration
         $client = Soap::baseWsdl('https://www.w3schools.com/xml/tempconvert.asmx?wsdl')
                       ->withOptions([
                           'soap_version' => SOAP_1_2,
-                          'location' => 'https://www.w3schools.com/xml/tempconvert.asmx?wsdl'
+                          'location' => 'https://www.w3schools.com/xml/tempconvert.asmx?wsdl',
                       ]);
         $result = $client->call('FahrenheitToCelsius', [
-            'Fahrenheit' => 75
+            'Fahrenheit' => 75,
         ]);
         self::assertArrayHasKey('FahrenheitToCelsiusResult', $result->json());
     }