refactor: Restructure test fixtures (#15)

Author: paulbalandan

composer.json

@@ -46,9 +46,9 @@
         }
     },
     "autoload-dev": {
-        "psr-4": {
-            "CodeIgniter\\PHPStan\\Tests\\": "tests/"
-        }
+        "classmap": [
+            "tests/"
+        ]
     },
     "config": {
         "allow-plugins": {

phpstan.neon.dist

@@ -12,12 +12,10 @@ parameters:
     analyseAndScan:
       - src/ComposerJsonRewriter.php
       - src/ComposerScripts.php
-      - tests/Fixtures
+      - tests/*/data/*
   tmpDir: build/phpstan
   bootstrapFiles:
     - vendor/codeigniter4/framework/system/Test/bootstrap.php
-  scanDirectories:
-    - vendor/codeigniter4/framework/system/Helpers
   codeigniter:
     additionalModelNamespaces:
       - CodeIgniter\PHPStan\Tests\Fixtures\Type

tests/Rules/Classes/CacheHandlerInstantiationRuleTest.php

@@ -36,7 +36,7 @@ protected function getRule(): Rule
 
     public function testRule(): void
     {
-        $this->analyse([__DIR__ . '/../../Fixtures/Rules/Classes/cache-handler.php'], [
+        $this->analyse([__DIR__ . '/data/cache-handler.php'], [
             [
                 'Calling new FileHandler() directly is incomplete to get the cache instance.',
                 19,

tests/Rules/Classes/FrameworkExceptionInstantiationRuleTest.php

@@ -35,7 +35,7 @@ protected function getRule(): Rule
 
     public function testRule(): void
     {
-        $this->analyse([__DIR__ . '/../../Fixtures/Rules/Classes/framework-exception.php'], [
+        $this->analyse([__DIR__ . '/data/framework-exception.php'], [
             [
                 'Instantiating FrameworkException using new is not allowed. Use one of its named constructors instead.',
                 17,

tests/Fixtures/Rules/Classes/cache-handler.php renamed to tests/Rules/Classes/data/cache-handler.php

@@ -54,8 +54,8 @@ protected function getRule(): Rule
     public function testRule(): void
     {
         $this->analyse([
-            __DIR__ . '/../../Fixtures/Type/config.php',
-            __DIR__ . '/../../Fixtures/Type/model.php',
+            __DIR__ . '/../../Type/data/config.php',
+            __DIR__ . '/../../Type/data/model.php',
         ], [
             [
                 'Parameter #1 $name of function config expects a valid class string, \'bar\' given.',
@@ -107,6 +107,6 @@ public function testRule(): void
     public function testAllowNonModelClassesOnModelCall(): void
     {
         $this->checkArgumentTypeOfModel = false;
-        $this->analyse([__DIR__ . '/../../Fixtures/Rules/Functions/bug-8.php'], []);
+        $this->analyse([__DIR__ . '/data/bug-8.php'], []);
     }
 }

tests/Fixtures/Rules/Classes/framework-exception.php renamed to tests/Rules/Classes/data/framework-exception.php

@@ -41,9 +41,9 @@ protected function getRule(): Rule
     public function testRule(): void
     {
         $this->analyse([
-            __DIR__ . '/../../Fixtures/Type/config.php',
-            __DIR__ . '/../../Fixtures/Type/factories-in-tests.php',
-            __DIR__ . '/../../Fixtures/Type/model.php',
+            __DIR__ . '/../../Type/data/config.php',
+            __DIR__ . '/../../Type/data/factories-in-tests.php',
+            __DIR__ . '/../../Type/data/model.php',
         ], [
             [
                 'Call to function config with CodeIgniter\Shield\Config\AuthJWT::class is discouraged.',
@@ -65,6 +65,6 @@ public function testRule(): void
 
     public function testOnAppNamespaceWithNonAppCall(): void
     {
-        $this->analyse([__DIR__ . '/../../Fixtures/Rules/Functions/bug-9.php'], []);
+        $this->analyse([__DIR__ . '/data/bug-9.php'], []);
     }
 }

tests/Rules/Functions/FactoriesFunctionArgumentTypeRuleTest.php

@@ -39,7 +39,7 @@ protected function getRule(): Rule
 
     public function testRule(): void
     {
-        $this->analyse([__DIR__ . '/../../Fixtures/Type/services.php'], [
+        $this->analyse([__DIR__ . '/../../Type/data/services.php'], [
             [
                 'The method \'createRequest\' is reserved for service location internals and cannot be used as a service method.',
                 51,

tests/Rules/Functions/NoClassConstFetchOnFactoriesFunctionsTest.php

@@ -37,7 +37,7 @@ protected function getRule(): Rule
 
     public function testRule(): void
     {
-        $this->analyse([__DIR__ . '/../../Fixtures/Rules/Superglobals/superglobal-access-cases.php'], [
+        $this->analyse([__DIR__ . '/data/superglobal-access-cases.php'], [
             [
                 'Accessing offset \'foo\' directly on $_SERVER is discouraged.',
                 21,

tests/Rules/Functions/ServicesFunctionArgumentTypeRuleTest.php

@@ -37,7 +37,7 @@ protected function getRule(): Rule
 
     public function testRule(): void
     {
-        $this->analyse([__DIR__ . '/../../Fixtures/Rules/Superglobals/superglobal-assign-cases.php'], [
+        $this->analyse([__DIR__ . '/data/superglobal-assign-cases.php'], [
             [
                 'Assigning \'https://localhost\' directly on offset \'HTTP_HOST\' of $_SERVER is discouraged.',
                 18,

tests/Fixtures/Rules/Functions/bug-8.php renamed to tests/Rules/Functions/data/bug-8.php

@@ -37,12 +37,12 @@ public function testFileAsserts(string $assertType, string $file, mixed ...$args
      */
     public static function provideFileAssertsCases(): iterable
     {
-        yield from self::gatherAssertTypes(__DIR__ . '/../Fixtures/Type/config.php');
+        yield from self::gatherAssertTypes(__DIR__ . '/data/config.php');
 
-        yield from self::gatherAssertTypes(__DIR__ . '/../Fixtures/Type/fake.php');
+        yield from self::gatherAssertTypes(__DIR__ . '/data/fake.php');
 
-        yield from self::gatherAssertTypes(__DIR__ . '/../Fixtures/Type/model.php');
+        yield from self::gatherAssertTypes(__DIR__ . '/data/model.php');
 
-        yield from self::gatherAssertTypes(__DIR__ . '/../Fixtures/Type/services.php');
+        yield from self::gatherAssertTypes(__DIR__ . '/data/services.php');
     }
 }

tests/Fixtures/Rules/Functions/bug-9.php renamed to tests/Rules/Functions/data/bug-9.php

@@ -37,6 +37,6 @@ public function testFileAsserts(string $assertType, string $file, mixed ...$args
      */
     public static function provideFileAssertsCases(): iterable
     {
-        yield from self::gatherAssertTypes(__DIR__ . '/../Fixtures/Type/model-find.php');
+        yield from self::gatherAssertTypes(__DIR__ . '/data/model-find.php');
     }
 }