@@ -126,7 +126,7 @@ function PlayerCtrl ($scope, $timeout, $interval, $element) {
126
126
}
127
127
128
128
function onFrameChange ( frame ) {
129
- // one frame in this method is one game turn, and contians subframes for each agent's actions
129
+ // one frame in this method is one game turn, and contains subframes for each agent's actions
130
130
for ( let i in ctrl . data . ids ) {
131
131
$scope . agents [ i ] . stdout = null
132
132
$scope . agents [ i ] . stderr = null
@@ -135,14 +135,7 @@ function PlayerCtrl ($scope, $timeout, $interval, $element) {
135
135
$scope . referee = { }
136
136
const frameData = ctrl . parsedGameInfo . frames [ frame ]
137
137
for ( let i in ctrl . data . ids ) {
138
- let subframe
139
- if ( frameData . subframes . length > 1 ) {
140
- subframe = frameData . subframes [ i ]
141
- } else {
142
- if ( frameData . subframes [ 0 ] . agentId === i ) {
143
- subframe = frameData . subframes [ 0 ]
144
- }
145
- }
138
+ const subframe = frameData . subframes . find ( subframe => subframe . agentId === i )
146
139
if ( subframe ) {
147
140
if ( subframe . stdout ) {
148
141
$scope . agents [ i ] . stdout = subframe . stdout
@@ -186,6 +179,7 @@ function PlayerCtrl ($scope, $timeout, $interval, $element) {
186
179
// check that at turn i, agent has output not null, so it is agent's turn
187
180
if ( output [ i ] != null && agentId !== 'referee' ) {
188
181
frames [ i ] . agentId = agentId
182
+ break
189
183
}
190
184
}
191
185
}
0 commit comments