refactor(SDK): Variable naming

Bullle · Bullle · commit aa0cdd04f61c · 2019-04-03T14:43:48.000+02:00
diff --git a/engine/modules/toggle/src/main/resources/view/toggle-module/ToggleModule.js b/engine/modules/toggle/src/main/resources/view/toggle-module/ToggleModule.js
@@ -84,18 +84,18 @@ function insertNewDuplicate (duplicates, matchedPair, key) {
 }
 
 function checkDuplicates (option) {
-  var values = []
+  var previousOptionValues = []
 
   ToggleModule.duplicateErrors[option.toggle] = {}
 
   for (const key in option.values) {
     const value = option.values[key]
-    const matchedPair = values.find(elem => elem.value === value)
+    const matchedPair = previousOptionValues.find(elem => elem.value === value)
 
     if (matchedPair) {
       insertNewDuplicate(ToggleModule.duplicateErrors[option.toggle], matchedPair, key)
     } else {
-      values.push({ key, value })
+      previousOptionValues.push({ key, value })
     }
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -84,18 +84,18 @@ function insertNewDuplicate (duplicates, matchedPair, key) {`
`84`	`84`	`}`
`85`	`85`
`86`	`86`	`function checkDuplicates (option) {`
`87`		`- var values = []`
	`87`	`+ var previousOptionValues = []`
`88`	`88`
`89`	`89`	`ToggleModule.duplicateErrors[option.toggle] = {}`
`90`	`90`
`91`	`91`	`for (const key in option.values) {`
`92`	`92`	`const value = option.values[key]`
`93`		`- const matchedPair = values.find(elem => elem.value === value)`
	`93`	`+ const matchedPair = previousOptionValues.find(elem => elem.value === value)`
`94`	`94`
`95`	`95`	`if (matchedPair) {`
`96`	`96`	`insertNewDuplicate(ToggleModule.duplicateErrors[option.toggle], matchedPair, key)`
`97`	`97`	`} else {`
`98`		`- values.push({ key, value })`
	`98`	`+ previousOptionValues.push({ key, value })`
`99`	`99`	`}`
`100`	`100`	`}`
`101`	`101`	`}`