Merge branch '5479-sdk-when-module-init-fails-no-whitescreen' into 'master'

fix(SDK): improve module error handling

See merge request codingame/game-engine!178

Author: Jean Poree

engine/core/src/main/resources/view/core/Drawer.js

@@ -72,6 +72,10 @@ export class Drawer {
   handleModuleError (name, error) {
     ErrorLog.push(new ModuleError(name, error))
     console.error(error)
+    ErrorLog.push({
+      message: `< module "${name}" disabled >\n`
+    })
+    delete this.modules[name]
   }
 
   instantiateModules () {
@@ -418,11 +422,15 @@ export class Drawer {
     for (let moduleName in this.modules) {
       const module = this.modules[moduleName]
       var stage = new PIXI.Container()
-      module.reinitScene(stage, {
-        width: scope.canvasWidth,
-        height: scope.canvasHeight,
-        oversampling: this.oversampling
-      })
+      try {
+        module.reinitScene(stage, {
+          width: scope.canvasWidth,
+          height: scope.canvasHeight,
+          oversampling: this.oversampling
+        })
+      } catch (error) {
+        this.handleModuleError(moduleName, error)
+      }
       container.addChild(stage)
     }
   }
@@ -513,10 +521,6 @@ export class Drawer {
           module.animateScene(step)
         } catch (e) {
           this.handleModuleError(moduleName, e)
-          ErrorLog.push({
-            message: `< module ${moduleName} disabled >`
-          })
-          module.animateScene = null
         }
       }
     }

engine/core/src/main/resources/view/core/ModuleError.js

@@ -1,6 +1,6 @@
 export class ModuleError extends Error {
   constructor (moduleName, cause) {
-    super('Error in module ' + moduleName)
+    super('< Error in module "' + moduleName + '" >')
     this.cause = cause
     this.name = 'ModuleError'
   }

playground/misc/misc-3-release-notes.md

@@ -2,6 +2,12 @@
 
 The CodinGame SDK is regularly updated and improved. This document lets you know what changed in the latest releases.
 
+# Next Release
+
+### 🐞 Bug fix
+
+- Better handling of errors from initializing modules
+
 ## 3.3.1
 
 ### 🐞 Bug fix