Skip to content

Commit 9fb2378

Browse files
authored
[libcxx] [test] Merge the MinGW static/shared test config files (llvm#111759)
These were split in 0e8208e, with the only functional difference between them at the time being `--prepend_env PATH=%{lib-dir}` in the static config and `--prepend_env PATH=%{install-prefix}/bin` in the shared library config. However this difference is unnecessary - the static library config doesn't need any `--prepend_env` argument at all. Before 0e8208e, both configurations used the same config file, where the `--prepend_env` argument was unnecessary but benign in the static case. Reduce the unnecessary config duplication in this case, and return these configs to using one single config file for both setups.
1 parent 82ac399 commit 9fb2378

File tree

3 files changed

+2
-31
lines changed

3 files changed

+2
-31
lines changed

libcxx/CMakeLists.txt

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -131,11 +131,7 @@ option(LIBCXX_ENABLE_VENDOR_AVAILABILITY_ANNOTATIONS
131131
if (CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
132132
set(LIBCXX_DEFAULT_TEST_CONFIG "llvm-libc++-shared-gcc.cfg.in")
133133
elseif(MINGW)
134-
if (LIBCXX_ENABLE_SHARED)
135-
set(LIBCXX_DEFAULT_TEST_CONFIG "llvm-libc++-shared-mingw.cfg.in")
136-
else()
137-
set(LIBCXX_DEFAULT_TEST_CONFIG "llvm-libc++-static-mingw.cfg.in")
138-
endif()
134+
set(LIBCXX_DEFAULT_TEST_CONFIG "llvm-libc++-mingw.cfg.in")
139135
elseif(WIN32) # clang-cl
140136
if (LIBCXX_ENABLE_SHARED)
141137
set(LIBCXX_DEFAULT_TEST_CONFIG "llvm-libc++-shared-clangcl.cfg.in")

libcxx/test/configs/llvm-libc++-shared-mingw.cfg.in renamed to libcxx/test/configs/llvm-libc++-mingw.cfg.in

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# This testing configuration handles running the test suite against LLVM's libc++
2-
# using a DLL with MinGW/Clang on Windows.
2+
# using either a DLL or a static library, with MinGW/Clang on Windows.
33

44
lit_config.load_config(config, '@CMAKE_CURRENT_BINARY_DIR@/cmake-bridge.cfg')
55

libcxx/test/configs/llvm-libc++-static-mingw.cfg.in

Lines changed: 0 additions & 25 deletions
This file was deleted.

0 commit comments

Comments
 (0)