Change error logs to debug for trigger type parsing #297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvanTopolcic
changed the title
tianchu
reviewed
Aug 2, 2022
| @@ -303,7 +303,7 @@ export function extractTriggerTags(event: any, context: Context) { | |||
| try { | |||
| eventSourceARN = parseEventSourceARN(eventSource, event, context); | |||
| } catch (error) { | |||
| logError(`failed to extract ${eventSource} arn from the event`, { error }); | |||
| logDebug(`failed to extract ${eventSource} arn from the event`, { error }); | |||
There was a problem hiding this comment.
BTW, is there any problem with the way we log { error }? From both user reports, I didn't see any error being logged, which is probably the most valuable part of this log.
There was a problem hiding this comment.
Yeah this is actually super confusing because looking at the code all it seems like we're doing is returning a field in an object and somehow an error is being thrown. I've tried to replicate it here.
Codecov Report
@@ Coverage Diff @@
## main #297 +/- ##
=======================================
Coverage 80.05% 80.05%
=======================================
Files 36 36
Lines 1715 1715
Branches 387 387
=======================================
Hits 1373 1373
Misses 290 290
Partials 52 52
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
These logs are not technically errors, as they're expected flow in some cases. For example, event bridge triggers do not necessarily need to be ARNs.
Motivation
Testing Guidelines
Additional Notes
Types of Changes
Check all that apply