fix integration tests #311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #311 +/- ##
=======================================
Coverage 80.05% 80.05%
=======================================
Files 36 36
Lines 1715 1715
Branches 387 387
=======================================
Hits 1373 1373
Misses 290 290
Partials 52 52
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
joeyzhao2018
commented
Oct 14, 2022
| @@ -7,7 +7,6 @@ provider: | |||
| environment: | |||
| DD_INTEGRATION_TEST: true | |||
| DD_API_KEY: ${env:DD_API_KEY} | |||
| lambdaHashingVersion: 20201221 | |||
There was a problem hiding this comment.
Ran serverless doctor and found it's deprecated.
joeyzhao2018
commented
Oct 18, 2022
| @@ -10,7 +10,7 @@ | |||
| "author": "", | |||
| "license": "ISC", | |||
| "dependencies": { | |||
| "axios": ">=0.21.2" | |||
| "axios": ">=1.1.3" | |||
There was a problem hiding this comment.
It turns out that newer versions of axios will add the Accept-Encoding header to the http requests. Therefore we should update the minimum version here. We also don't want to set the version at a fixed number since this can potentially reveal issues with newer versions of axios.
joeyzhao2018
commented
Oct 18, 2022
|
|
||
| if (options.headers) { | ||
| const headerStrings = Object.entries(options.headers).map(([name, value]) => `${name}:${value}`); | ||
| if (traceHeaders) { |
There was a problem hiding this comment.
Instead of logging all the headers here, only log the relevant ones ,i.e. the Trace context headers.
duncanista
approved these changes
Oct 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Motivation
Testing Guidelines
Additional Notes
Types of Changes
Check all that apply