Skip to content

Revert "Lazy load metrics listener (#320)" #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 20, 2022
Merged

Conversation

joeyzhao2018
Copy link
Contributor

@joeyzhao2018 joeyzhao2018 commented Dec 20, 2022

This reverts commit 47c5508.

What does this PR do?

Revert the commit 47c5508 as it is causing the metrics and traces not sent.
The tests done for the original commit 47c5508 was not correctly setup and caused confusion.

Motivation

Testing Guidelines

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@joeyzhao2018 joeyzhao2018 marked this pull request as ready for review December 20, 2022 21:00
@joeyzhao2018 joeyzhao2018 requested a review from a team as a code owner December 20, 2022 21:00
@astuyve astuyve merged commit 10e7c2c into main Dec 20, 2022
@astuyve astuyve deleted the joey/revert-47c55084 branch December 20, 2022 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants